Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct example usage of SES data class #209

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

to-mc
Copy link
Contributor

@to-mc to-mc commented Nov 19, 2020

Issue #, if available: #208

Description of changes: Fix incorrect documentation of SES dataclass example.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Nov 19, 2020

Codecov Report

Merging #209 (4fe50e8) into develop (7b8fd7c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #209   +/-   ##
========================================
  Coverage    99.88%   99.88%           
========================================
  Files           69       69           
  Lines         2543     2543           
  Branches       109      109           
========================================
  Hits          2540     2540           
  Misses           3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b8fd7c...4fe50e8. Read the comment docs.

Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@heitorlessa heitorlessa merged commit f7bb809 into develop Nov 19, 2020
@heitorlessa heitorlessa deleted the docs/correct_ses_dataclass_example branch November 19, 2020 14:38
@michaelbrewer
Copy link
Contributor

Thanks for fixing this.

@heitorlessa heitorlessa added the documentation Improvements or additions to documentation label Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants