Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add event object sent from Cloudwatch Alarms #3848

Closed
1 of 2 tasks
jaydm26 opened this issue Feb 24, 2024 · 7 comments
Closed
1 of 2 tasks

Feature request: Add event object sent from Cloudwatch Alarms #3848

jaydm26 opened this issue Feb 24, 2024 · 7 comments
Assignees
Labels
event_sources Event Source Data Class utility feature-request feature request

Comments

@jaydm26
Copy link

jaydm26 commented Feb 24, 2024

Use case

AWS has added a trigger for Cloudwatch Alarms that can trigger lambdas. Thus, it would be helpful to include this in the available data classes.

More on the event object can be found here: https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/AlarmThatSendsEmail.html#alarms-and-actions

Solution/User Experience

The required data classes are added to AWS Powertools

Alternative solutions

No response

Acknowledgment

@jaydm26 jaydm26 added feature-request feature request triage Pending triage from maintainers labels Feb 24, 2024
Copy link

boring-cyborg bot commented Feb 24, 2024

Thanks for opening your first issue here! We'll come back to you as soon as we can.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

@leandrodamascena
Copy link
Contributor

Hi @jaydm26! Thanks for opening this issue and remembering that we need to add this new event source data class.

Do you want to send a PR to implement this? We'd love to have your first contribution here 🚀.

@leandrodamascena leandrodamascena removed the triage Pending triage from maintainers label Feb 27, 2024
@jaydm26
Copy link
Author

jaydm26 commented Feb 27, 2024

Hi @leandrodamascena

I would be happy to. Might take some time to implement it.

If someone takes it up before I take it up, go ahead. I will update the thread again when I begin.

@par6n
Copy link
Contributor

par6n commented Feb 28, 2024

I have opened a pull request (still on draft) for this, as I've already implemented something similar in my team. I'd be more than happy to hear your feedback/comments/opinions on the changes! 😃

@rubenfonseca
Copy link
Contributor

@par6n awesome work! Feel free to publish the PR and I'll be happy to review and help you merge your contribution!

@rubenfonseca rubenfonseca added the event_sources Event Source Data Class utility label Feb 29, 2024
@rubenfonseca rubenfonseca self-assigned this Feb 29, 2024
@leandrodamascena
Copy link
Contributor

Closing as completed!

Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event_sources Event Source Data Class utility feature-request feature request
Projects
Status: Shipped
Development

No branches or pull requests

4 participants