Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data_sources): ensure correct types on SQSMessageAttributes #3898

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

rubenfonseca
Copy link
Contributor

@rubenfonseca rubenfonseca commented Mar 7, 2024

Issue number: #3880

Summary

Changes

Please provide a summary of what's being changed

This PR changes the way you access SQSMessageAttributes to return the same type of objects you get when you use the __getitem__ magic method.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@rubenfonseca rubenfonseca requested a review from a team as a code owner March 7, 2024 12:00
@boring-cyborg boring-cyborg bot added the tests label Mar 7, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 7, 2024
@github-actions github-actions bot added the bug Something isn't working label Mar 7, 2024
@rubenfonseca rubenfonseca added the event_sources Event Source Data Class utility label Mar 7, 2024
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rubenfonseca rubenfonseca merged commit f1b95d2 into develop Mar 8, 2024
14 checks passed
@rubenfonseca rubenfonseca deleted the rf/3880 branch March 8, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working event_sources Event Source Data Class utility size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: SQSMessageAttributes __getitem__ has a different type to items() values
2 participants