Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Use updated names for ProxyEventType #424

Merged
merged 1 commit into from
May 6, 2021

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented May 6, 2021

Issue #, if available:

Description of changes:

Use the updated names for ProxyEventType which are now CamelCased.

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@michaelbrewer
Copy link
Contributor Author

@heitorlessa maybe we can hotfix the docs under v1.15.0? as we are not modifying the actually shipped code.

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2021

Codecov Report

Merging #424 (641ec73) into develop (bd1dbf0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #424   +/-   ##
========================================
  Coverage    99.89%   99.89%           
========================================
  Files          101      101           
  Lines         3994     3994           
  Branches       198      198           
========================================
  Hits          3990     3990           
  Misses           1        1           
  Partials         3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd1dbf0...641ec73. Read the comment docs.

@heitorlessa heitorlessa added the documentation Improvements or additions to documentation label May 6, 2021
@heitorlessa
Copy link
Contributor

heitorlessa commented May 6, 2021

Ugh, missed that. Sure, I'll update it tomorrow morning.

I'll keep it open in case someone comes looking until tomorrow

Update: Scratch that, this will be best merged and available under develop version for now.

Thank you!

@heitorlessa heitorlessa merged commit e5381ae into aws-powertools:develop May 6, 2021
@michaelbrewer michaelbrewer deleted the fix-docs-api-gateway branch May 6, 2021 18:43
heitorlessa added a commit that referenced this pull request May 6, 2021
heitorlessa added a commit that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants