Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-classes): underscore support in api gateway authorizer resource name #969

Merged

Conversation

michaelbrewer
Copy link
Contributor

Issue #, if available:

Description of changes:

When building a authorizer response we should allow for underscores in the resource

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

When building a authorizer response we should allow for underscores in the resource
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 20, 2022
@michaelbrewer
Copy link
Contributor Author

@heitorlessa check slack message for addtional context: https://awsdevelopers.slack.com/archives/C01A6KK4UFK/p1642710260031500

@heitorlessa heitorlessa changed the title fix(data-classes): All for underscore in resource name fix(data-classes): underscore support in api gateway authorizer resource name Jan 21, 2022
@heitorlessa heitorlessa added the bug Something isn't working label Jan 21, 2022
@heitorlessa heitorlessa merged commit 2ad7dc4 into aws-powertools:develop Jan 21, 2022
@heitorlessa heitorlessa deleted the fix-allow-resource-with-underscore branch January 21, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants