Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Detection of hardware encoder is incorrect #36

Closed
mm318 opened this issue Oct 16, 2019 · 3 comments
Closed

Detection of hardware encoder is incorrect #36

mm318 opened this issue Oct 16, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@mm318
Copy link
Member

mm318 commented Oct 16, 2019

With #35, there is an initial attempt to open the h264_omx encoder to detect whether or not it is available. However, the attempt to open it gives a message like:

[h264_video_encoder-11] [h264_omx @ 0xea8260] The encoder timebase is not set.

and fails to correctly identify that the encoder is actually there available and working.

I suspect this is because the h264_omx encoder is being attempted to be opened in is_codec_available() with unset parameters (where the timebase, or framerate, is not set as the error message above indicates).

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.97. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the bug Something isn't working label Oct 16, 2019
@mm318 mm318 assigned mm318 and ryanewel and unassigned mm318 Oct 16, 2019
@ryanewel
Copy link
Member

A fix has been merged into master. Leaving this issue open until the release is available in apt

@mm318
Copy link
Member Author

mm318 commented Feb 5, 2020

The fix has been released to version 2.0.3.

@mm318 mm318 closed this as completed Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants