Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribute initial sample code #1

Merged
merged 3 commits into from Dec 10, 2021
Merged

Contribute initial sample code #1

merged 3 commits into from Dec 10, 2021

Conversation

julicjung
Copy link
Contributor

Description of changes:

  • The initial sample code

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

fbdo
fbdo reviewed Dec 10, 2021
View reviewed changes
Copy link
Contributor

@fbdo fbdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the license headers, make sure they are all MIT-0. We have a file coming from a different project (mvn) with a different license, so we need to create a THIRD-PARTY-LICENSES.txt file.

.mvn/wrapper/MavenWrapperDownloader.java Outdated Show resolved Hide resolved
cdk/bin/app-config-app.ts Show resolved Hide resolved
cdk/lib/app-config-stack.ts Show resolved Hide resolved
cdk/package.json Show resolved Hide resolved
mvnw Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
fbdo
fbdo reviewed Dec 10, 2021
View reviewed changes
Copy link
Contributor

@fbdo fbdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments on to move code to more specific packages

src/main/java/com/amazon/config/source/AwsAppConfigSource.java Outdated Show resolved Hide resolved
src/test/java/com/amazon/LoanResourceTest.java Outdated Show resolved Hide resolved
src/test/java/com/amazon/NativeLoanResourceIT.java Outdated Show resolved Hide resolved
Changed license headers and package name
e9d4fff 
All changes as requested in the PR to merge into the sample repo.
Maven wrapper was completely removed, as it is not strictly
necessary for the sample. It has to be user-provided now.
fbdo
fbdo approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@fbdo fbdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes approved, merging changes.

@fbdo fbdo merged commit d97a4d3 into aws-samples:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbdo fbdo fbdo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julicjung @fbdo