Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move books.json and seed datasets into user's asset bucket/CDN #26

Open
benoitdechateauvieux opened this issue Jun 8, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@benoitdechateauvieux
Copy link

Describe the bug
The DDB table is populated using https://aws-bookstore-demo.s3.amazonaws.com/data/books.json
URLs in this file are based on the d2z6cj5wcte8g7.cloudfront.net distribution which seems not to exist anymore.

To Reproduce
Steps to reproduce the behavior:

  1. Launch the CF stack
  2. Once complete, open the home page
  3. Scroll down to 'Cookbooks' section
  4. See error: Books cover are not displayed
@triggan
Copy link
Contributor

triggan commented Nov 3, 2021

The book images are still out there, but they are no long behind that CloudFront distribution. Likely that we need to refactor the code to to download the book images as an asset and include them in the assets bucket that gets deployed in the user's account as part of the stack deployment. Instead of having them in a shared location behind a CF distribution. But if you want to see the images, they are at:

https://s3.amazonaws.com/aws-bookstore-demo/book-covers/

@bloomqa
Copy link

bloomqa commented Nov 10, 2021

@triggan thanks for the update here. When I tried accessing the s3 link I just get a blank download. Is there something I'm missing?

@triggan
Copy link
Contributor

triggan commented Oct 28, 2022

This has been addressed. The books images are now behind a new CloudFront distribution and the books.json has been updated to reference the new distribution. Leaving this Issue open as we would like to change the stack behavior to host the images within the same account as the deployed stack. Today, all deployed stacks will use images hosted in a centralized account. We will need to create a new process for generating the books.json file dynamically and update the image URLs at the time the stack is deployed.

@triggan triggan changed the title Broken URL in books.json Move books.json and seed datasets into user's asset bucket/CDN Nov 23, 2022
@triggan triggan added the enhancement New feature or request label Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants