Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate keeping package.json in sync with latest CDK version #13

Closed
SoManyHs opened this issue Mar 5, 2019 · 4 comments
Closed

Automate keeping package.json in sync with latest CDK version #13

SoManyHs opened this issue Mar 5, 2019 · 4 comments

Comments

@SoManyHs
Copy link
Contributor

SoManyHs commented Mar 5, 2019

Any updates to CDK construct libs require manual update of package.json in every example. We should probably try to figure out a better way to do this.
@SoManyHs SoManyHs changed the title Better way of updating package.json Automate keeping package.json in sync with latest CDK version Mar 5, 2019
@simalexan
Copy link
Contributor

They don't, they are automatically set to the highest version:
Example: "@aws-cdk/cdk": "*"
And thats set within tests too, the tests will fail if a version is set.

@simalexan
Copy link
Contributor

@SoManyHs I think this one is solved already, as per comment above.

@rix0rrr what do you think?

@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 5, 2019

Yep, you are right.

@rix0rrr rix0rrr closed this as completed Jun 5, 2019
@simalexan
Copy link
Contributor

@rix0rrr thank you for your quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rix0rrr @simalexan @SoManyHs