Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to compile : ui-frontend\src\components\AppLayout\index.tsx #3

Closed
markyates opened this issue Jan 27, 2022 · 3 comments
Closed

Comments

@markyates
Copy link

Failed to compile.

TS2322: Type '{ header: { text: string; href: string; }; expanded: boolean; items: SideNavigationItem[]; }' is not assignable to type 'IntrinsicAttributes & (IntrinsicClassAttributes<Component<Pick<SideNavigationProps, "header" | "items"> & ({} | { wrappedComponentRef?: Ref | undefined; }), any, any>> & (Readonly<...> & Readonly<...>))'.
Property 'expanded' does not exist on type 'IntrinsicAttributes & (IntrinsicClassAttributes<Component<Pick<SideNavigationProps, "header" | "items"> & ({} | { wrappedComponentRef?: Ref | undefined; }), any, any>> & (Readonly<...> & Readonly<...>))'.
17 | return <SideNavigationBase
18 | header={{text: 'Demo', href: '/'}}

19 | expanded={false}
| ^^^^^^^^
20 | items={
21 | getNavigation()
22 | }

@markyates
Copy link
Author

Builds with:

return <SideNavigationBase
    header={{text: 'Demo', href: '/'}}
    /*expanded={false}*/
    items={
      getNavigation()

@kevhiggi
Copy link
Contributor

Thanks for reporting the issue. NorthStar makes changes from one build to another build and sometimes they are not backward compatible. We will have an update shortly.

@kevhiggi
Copy link
Contributor

NorthStar will be adding an expandedAll props in the SideNavigation in a future release - for now, we have removed the expanded property in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants