Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues and fixes while deploying #4

Closed
DeepaliTandale opened this issue Oct 17, 2023 · 1 comment
Closed

Issues and fixes while deploying #4

DeepaliTandale opened this issue Oct 17, 2023 · 1 comment

Comments

@DeepaliTandale
Copy link

Hi, Below are the issues I saw when I was trying to deploy git code. Hopefully it helps.

  1. It only works for Nodev16, but if i update to Nodev20 deployment failed for me.
  2. npm install was needed before deployment, maybe if we can add this text in README.doc many users will find it useful.
  3. I had to comment out RUN pip install awscli --upgrade --user from DockerFile
  4. I updated CLI, aws-cdk, python version to the latest since it was failing to move ahead.
  5. I had to move to cloud9 because Mac M1 is not supported to pull docker image. would be helpful, if we can mention this somewhere on the document (I struggled and started looking for different container image).

specific to the text which lead to confusion, if we can edit that will be easy for future users.

  1. Issue -> For statement Configure defaultVpcId with an existing vpc ID. If you're integrating to Amazon MQ, you also need to configure a hostedZone parameter.
    Fix -> Default VPC didn't work in my case, had to create a new one using the quip setup.
  2. "hostedZone": "fqdn-zone", // Optional: Route53 Zone (Public and Private) used for Amazon MQ integration
    Fix -> For me only private hosted zone worked. I checked code, since it was only accessing privatehostedZone, so had to create a private zone.
@rinaudjaws
Copy link
Collaborator

rinaudjaws commented Oct 17, 2023

  1. What error did you get when deploying?
  2. npm install not needed, please use yarn install a mentioned in the README.
  3. Fixed broken dependency (Unable to install aws-cli via pip - package dependency broke aws/aws-cli#8036)
  4. Should be fixed with the AWS CLI --no-build-isolation flag (see issue above).
  5. M1 not supported by IBM MQ docker, will add limitation: https://integration-development.ideas.ibm.com/ideas/MESNS-I-369

Issues:

  1. I'll add note that VPC should have at least private and public subnets.
  2. Private zone won't work because code generates certificates (ACM). See https://github.com/aws-samples/aws-ibm-mq-adapter/blob/main/lib/mq-amazon-mq-stack.ts#L47. You can't create certificates with private zone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants