Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work #29

Closed
aejuice-github opened this issue Jul 4, 2023 · 8 comments
Closed

Does not work #29

aejuice-github opened this issue Jul 4, 2023 · 8 comments

Comments

@aejuice-github
Copy link

I was following video example precisely. Even with your default values it does not work.

  1. I replaced a playlist with my playlist, the link is correct and has the same format. There is an error while building the index. It cannot crawl youtube video. The playlist is public.
  2. I used your playlist and once it deployed the web app link does not work. It says "Your app will appear here once you complete your first deployment.". Even though all steps were successful and it says it is deployed.

Great concept, but poor implementation. Is there a way to fix it?

@rstrahan
Copy link
Contributor

rstrahan commented Jul 4, 2023 via email

@aejuice-github
Copy link
Author

@rstrahan 1. Incorrect. Your playlist works because results are cached. According to your documentation, you do not parse videos twice. It does not work with any other playlist, I've tried plenty. In fact, we've debugged why it does not work. Your app uses a package pytube which is outdated. YouTube has changed the link structure and it cannot get a video. You can find more info and error message at https://stackoverflow.com/questions/68945080/pytube-exceptions-regexmatcherror-get-throttling-function-name-could-not-find

Here is a link to the playlist https://www.youtube.com/playlist?list=PLr7J3R1sT1C5pcB_xuhH1cTV9W19z1iDk

I hope you'll be able to resolve it. We would be very interested in using the service.

  1. You're correct. The issue is resolved.

@rstrahan
Copy link
Contributor

rstrahan commented Jul 4, 2023

@aejuice-github
OK, we'll look into (1) and post back.. Thanks for letting us know.

@rstrahan
Copy link
Contributor

rstrahan commented Jul 5, 2023

Confirming that I can easily repro the problem..

image

Referring to colleague who implemented this feature. Tx.

@roshansthomas
Copy link
Contributor

roshansthomas commented Jul 6, 2023

Regarding issue (1). Post investigation
The solution "does not" cache a playlist. When the playlist is changed the solution will index the videos per the new playlist (if they have not been indexed prior).
The issue that is currently causing the stack to fail is with pytube version 15.0.0. Issue - > (pytube/pytube#1707).
We are working to fix this in the interim while a permanent fix is made to the pytube main branch.

Also if you do not want to index the YT media, you could leave the playlist empty and only mention the S3 bucket source where your media is stored then the stack deploys successfully and indexes the media from s3.

@roshansthomas
Copy link
Contributor

Tested v0.3.1 which contains the pytube 15.0.0. fix.
I am now able to index youtube videos on the YT playlist provided as default value of the CFN template parameter. Also able to change the playlist to the playlist quoted in the issue above https://www.youtube.com/playlist?list=PLr7J3R1sT1C5pcB_xuhH1cTV9W19z1iDk. And the indexer picks up the new videos as well.
This issue is fixed and can be closed.

@rstrahan
Copy link
Contributor

rstrahan commented Jul 7, 2023

Release v0.3.1 based on your PR @roshansthomas addresses this issue. Updated artifacts published to the public S3 bucket.
(The fix is temporary, and applies only to the current version of pytube, 5.0.0. We expect that the next release of pytube will address the issue officially)
@aejuice-github please deploy again and report back if you encounter any remaining issues. Thanks again for letting us know about the problem.

@roshansthomas
Copy link
Contributor

Closing issue as the the solution now uses yt_dlp package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants