Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected nb names and add environment file #17

Merged
merged 2 commits into from Dec 1, 2021
Merged

Conversation

cemsaz
Copy link
Contributor

@cemsaz cemsaz commented Nov 12, 2021

Notebook names are changed according to the recordings and a new environment file is added.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@cemsaz cemsaz requested a review from bwerness November 12, 2021 17:45
@cemsaz cemsaz changed the title Corrected nb names Corrected nb names and add environment file Dec 1, 2021
Copy link
Contributor

@bwerness bwerness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that might help with the cuda version issue is adding a quick sentence saying "if this does not run please ensure that the cuda version matches" or something like that along with the command that reports on the cuda version

@bwerness bwerness merged commit b5ee762 into master Dec 1, 2021
@cemsaz cemsaz deleted the correct-nb-names branch December 10, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants