Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Application - Module 1 - Inconsistent expectations set on scope of GitHub account access required by Amplify #257

Open
ckamps opened this issue Dec 18, 2019 · 0 comments

Comments

@ckamps
Copy link
Contributor

ckamps commented Dec 18, 2019

When following the "Connect app..." workflow in the Amplify Console with a GitHub.com repository, it's clear that the Amplify Console requires more than just read only access to the user's GitHub account yet the Amplify console sets conflicting expectations and the workshop module's README.md does not set the degree of access expectations with the user so that the user can make a more informed decision.

This issue has also been filed in the aws-amplify organization on GitHub.com:

aws-amplify/amplify-hosting#329

Background

  1. When selecting GitHub.com, the Amplify console states: "Amplify Console requires read-only access to your repository."

image

  1. However, in the next step of the Amplify wizard, far more than just read only access to the user's repository is specified: "This application will be able to read and write all public and private repository data." i.e. the dialog implies that Amplify is requesting read and write access to all repositories, public and private, in the user's GitHub.com account.

image

Recommended Fixes

  1. Given these inconsistencies in the Amplify UI, the workshop module's documentation should accurately set the user's expectation concerning the degree of access required so that the user can make an informed decision.

Many users should and will decline to allow such broad write access to their GitHub account.

  1. Amplify's issues database should be reviewed to see if the inconsistent guidance is already filed as a bug. If it is not already filed, then a bug report should be filed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant