Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Unused region arg in eksctlfinal #24

Closed
quixoticmonk opened this issue Feb 11, 2023 · 0 comments · Fixed by #29
Closed

Maintenance: Unused region arg in eksctlfinal #24

quixoticmonk opened this issue Feb 11, 2023 · 0 comments · Fixed by #29

Comments

@quixoticmonk
Copy link
Contributor

quixoticmonk commented Feb 11, 2023

Summary

Methods below have a region argument which is already implicitly set with the boto3 client instance bclient.

  • eksctlfinal.py
    • upgrade_cluster
    • get_old_smg_node_groups
    • create_managed_nodegroup
    • create_unmanaged_nodegroup

Why is this needed?

Unused argument in the method definition.

Which area does this relate to?

Other

Solution

Remove the unused argument (region) in the above methods and update invocations without the region reference.

@quixoticmonk quixoticmonk changed the title Maintenance: Unused region arg in under few methods Maintenance: Unused region arg in eksctlfinal Feb 11, 2023
@bryantbiggs bryantbiggs linked a pull request Feb 12, 2023 that will close this issue
3 tasks
@bryantbiggs bryantbiggs removed a link to a pull request Feb 12, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant