Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load notebook instance directly from GitHub #104

Closed
james-jory opened this issue Oct 28, 2020 · 0 comments · Fixed by #259
Closed

Load notebook instance directly from GitHub #104

james-jory opened this issue Oct 28, 2020 · 0 comments · Fixed by #259
Assignees
Labels
deployment Related to project deployment workshop Related to a workshop experience

Comments

@james-jory
Copy link
Contributor

Given that the number of workshops and supporting screenshots and images has increased, we are running into the archive max size limit when initializing the workshop's CodeCommit repo. By switching from using a CodeCommit repo to directly cloning from a GitHub repo for the workshops, we avoid the limit issue. Besides, I think the current approach was being used before the project was open-sourced and publicly available for cloning into a SM instance (which is no longer the case).

The DefaultCodeRepository value on the NotebookInstance should default to the upstream repo (https://github.com/aws-samples/retail-demo-store.git) but support being overridden using the GitHubUser template parameter so developers can test changes from their fork. So something like:

DefaultCodeRepository: !Sub 'https://github.com/${GitHubUser}/retail-demo-store.git'

This will require the GitHubUser parameter to have a default of aws-samples in the root template.yaml.

Be sure to remove the steps in the root stage.sh that create and upload the retaildemostore-notebooks.zip file and verify that any notebook dependencies on the generator code and products & users data files are updated to refer to their original location in the repo. May just be the Amplitude workshop that is potentially impacted.

@james-jory james-jory added workshop Related to a workshop experience deployment Related to project deployment labels Oct 28, 2020
@james-jory james-jory self-assigned this Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Related to project deployment workshop Related to a workshop experience
Projects
None yet
1 participant