-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSCode disconnects after credentials refresh. #59
Comments
Hi, @harish-kamath , very nice that you like this library! I have few questions: |
On the bright side, it no longer crashes always after 30 mins of being connected. However, it is still crashing within an hour. |
Never mind, just got another crash in <30 minutes. I'm pretty sure it is still this package, because connecting over plain SSH is still fine and never causes a crash. |
Hi, @harish-kamath , apologies for delay, this indeed seems to me very strange. I will have to investigate it further since in the short-running tests it never crashed like that before. In a meantime, is it possible for you to raise the support case from AWS Console? Please, add the link to this issue and mention my name: https://docs.aws.amazon.com/awssupport/latest/user/case-management.html |
@harish-kamath I am using the following manual test to try to reproduce the issue. Without connection from VS Code the job successfully stops in 3 hours without any "Internal Server Error". I have few more asks and questions: 1/ What instance types did you try? 2/ Could you please run the test on sagemaker-ssh-helper/tests/test_manual.py Lines 23 to 50 in 0d70d02
3/ Don't connect with VS Code and wait for some time until credentials will refresh automatically for one or two times. The job should not crash. Then try to connect with VS Code. So far for me it seems that the issue has nothing to do with Credential refresh, because they are refreshed all the time automatically and this is expected. 4/ How likely is that the VS Code runs some heavy process inside and the instance is running out of RAM? Could you please check the utilization on the job page in AWS Console? The successful run looks like this: ![]() Make the note at which exact time the credentials were refreshed and what time you've connected with VS Code. I hope the above steps will help you to localize and isolate the issue down to some process that VS Code starts inside the container. |
Thank you for the great library! It works fine when I SSH in directly, no issues there. However, if I connect with VSCode, it'll work fine for the most part - until I see a log:
[sagemaker-ssh-helper][sm-setup-ssh][start-ssh] 2024-04-21 07:28:33 INFO [CredentialRefresher] Next credential rotation will be in 29.997197441433332 minutes
Then, the machine will fail within a minute or two of this message, and give the error
InternalServerError: We encountered an internal error. Please try again.
in Sagemaker.Weirdly enough, this is regardless of the instance type, amount of memory, etc. Also - it doesn't always happen the first time that message is sent, so I'm not sure if it's exactly that issue, or something else. Regardless, the machine fails with an internal server error only when I connect with VS Code after some amount of time connected.
The text was updated successfully, but these errors were encountered: