Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hex color codes on background_color filter do not work #154

Closed
adamhughes86 opened this issue Oct 16, 2019 · 2 comments
Closed

Hex color codes on background_color filter do not work #154

adamhughes86 opened this issue Oct 16, 2019 · 2 comments

Comments

@adamhughes86
Copy link

When I'm using the background_color filter I cannot get it to work with hex color codes. With named colors such as purple, red, indigo it works fine. As soon as it's changed to a hex code though the page returns an empty object. This happens when applied to transparent png's

Works: filters:background_color(red)
Breaks: filters:background_color(f00)
Breaks: filters:background_color(f00f00)
Breaks: filters:background_color(#f00f00)

@hayesry
Copy link
Member

hayesry commented Oct 17, 2019

Hey @adamhughes86. We've added a feature request to support hex codes in legacy mappings to the Thumbor-style URL paths. This issue exists because SharpJS doesn't support hex codes natively, thus requiring some custom conversion on our end into rgb(255, 255, 255) format. Thanks for bringing this to our attention!

@beomseoklee
Copy link
Member

We have updated our solution, and I believe your issue has been fixed. If you still see the issue with the latest version (v4.2), please feel free to reopen the issue.

You can refer to the recent changes here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants