Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images are automatically flipped when using serverless-image-handler #197

Closed
SilverFoxA opened this issue Mar 18, 2020 · 11 comments
Closed

Comments

@SilverFoxA
Copy link

I have an image already in AWS S3 bucket, which is exactly what it is and it's vertical. When I'm importing it to demo URL or using the endpoint URL it automatically gets flipped.

We are facing problem on our live server because of this, please suggest. We are using the latest version (4.2)

Image reference is added :

https://i.imgur.com/qwHu1cw.png

@beomseoklee
Copy link
Member

@SilverFoxA I'm sorry to hear you have an issue. It looks like the image on the preview side wasn't flipped. If I'm wrong, please correct me.

In addition, if you can share how I can reproduce, please let me know: 1) image file, 2) edits.

@SilverFoxA
Copy link
Author

SilverFoxA commented Mar 19, 2020

Hello @beomseoklee

Hope you are doing well.
Thank you for your prompt response.

Actual Image: https://i.imgur.com/s0I7rdN.jpg

But when I'm using serverless-image-handler and importing the file it gets flipped for no reason.
Does it have anything to do with the dimension?

To reproduce, simply upload the actual image to AWS S3 bucket, use the demo URL. Without any modification, you will be able to reproduce the error.

@beomseoklee
Copy link
Member

@SilverFoxA
I tried to reproduce the issue, but I couldn't.

  1. Original Image you provided
    image

  2. Demo UI Preview
    image

Would there be any other things that I can try?

@SilverFoxA
Copy link
Author

@beomseoklee Is it possible that you can share me any other means using which I can share with private credentials which you can view. I'll be able to share the endpoint URL.

@Karlen92
Copy link

Karlen92 commented Apr 7, 2020

@SilverFoxA I had a similar issue when working with react-native, the problem was connected not to image handler but with the image itself. The issue was caused by wrong exif information, which was included with the image.

This link can be helpful
GoogleChromeLabs/squoosh#299

@SilverFoxA
Copy link
Author

@Karlen92 How did you sort this? But when we are using the webserver file, everything seems fine, we are focused on the AWS Javascript SDK.

@Karlen92
Copy link

Karlen92 commented Apr 7, 2020

@SilverFoxA In my case, when the image contained exif information, I simply compressed it with no quality loss(which didn't touch image quality, it just created a new image). In backend, you can use jimp to resize your image (it would be fake resize, use the same dimensions as the image have), maybe that would help.

@alexga12
Copy link

alexga12 commented Jun 9, 2020

@SilverFoxA Are you having the same issue as #135 ?

@beomseoklee
Copy link
Member

Thanks for waiting. We've fixed this one in v5.1.0.
If you still see the issue in the newest version, please open an issue again.

@timlawrenz
Copy link

@SilverFoxA does v5.1.0 resolve the issue?

@fisenkodv
Copy link
Contributor

@SilverFoxA we have updated our solution, and I believe your issue has been fixed. If you still see the issue with the latest version (v6.0.0), please feel free to reopen the issue.

You can refer to the recent changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants