fix: typing issue for apply_hamiltonian #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 48 48
Lines 3745 3746 +1
Branches 910 910
=========================================
+ Hits 3745 3746 +1 ☔ View full report in Codecov by Sentry. |
speller26
reviewed
Mar 11, 2024
src/braket/analog_hamiltonian_simulator/rydberg/numpy_solver.py
Outdated
Show resolved
Hide resolved
| ] | ||
|
|
||
| dk_tilde = [ | ||
| np.linalg.solve( | ||
| np.eye(size_hilbert_space) + 1j * dt * _EIGVALS_A[i] * hamiltonian, | ||
| np.sum([_INV_EIGVECS_A[i][j] * kx[j] for j in range(_STAGES)], axis=0), | ||
| size_hilbert_space_eye_mat + 1j * dt * _EIGVALS_A[i] * hamiltonian, |
There was a problem hiding this comment.
Is it necessary to define size_hilbert_space_eye_mat when it's only used once?
There was a problem hiding this comment.
This obj is being recreated for each iteration of _STAGES when iterated through on L119 and then passed on to the solver (np.linalg.solve) on L115
speller26
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.