Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Optional ctrl for U, add tests #251

Merged
merged 1 commit into from
Apr 26, 2024
Merged

fix: Optional ctrl for U, add tests #251

merged 1 commit into from
Apr 26, 2024

Conversation

speller26
Copy link
Contributor

  • Makes ctrl_modifiers optional for the U gate
  • Add missing gates to simulation test data

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* Makes `ctrl_modifiers` optional for the `U` gate
* Add missing gates to simulation test data
@speller26 speller26 requested a review from krneta April 26, 2024 06:36
@speller26 speller26 requested a review from a team as a code owner April 26, 2024 06:36
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0bf40ca) to head (31f40f2).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #251   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         3712      3712           
  Branches       889       889           
=========================================
  Hits          3712      3712           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@speller26 speller26 merged commit 6d38d5c into main Apr 26, 2024
33 checks passed
@speller26 speller26 deleted the tests branch April 26, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants