Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoFrameRGBABuffer implementation of VideoFrameBuffer (within VideoFrame) having issues with VideoRenderView implementations #362

Closed
VadimChubarov opened this issue Jan 4, 2022 · 6 comments
Labels
Needs More Information Further information is requested

Comments

@VadimChubarov
Copy link

Describe the bug
The crash mentioned in this ticket #344 looks like was fixed, but as we have tested on our side seems remains couple of issues with this scenario.

  • VideoRenderView displays RGB video frame in mirror projection (without active mirror flag), in the same time other types of video frame displayed original. Setting mirror = true making this situation opposite.

  • when VideoRenderView working with RGB video frames after 1.5 - 3 minutes happens crash or app freeze (probably due to some sort of memory leak , attached profiler screenshots)

During the tests we have tried as much as possible exclude any affects on our side, so seems problems above related to VideoRenderView usage only, but it's needs to be reproduced on your side.

To Reproduce
Steps to reproduce the behavior:

Expected behavior
same like in #344

Screenshots

motorola one action
chime SDK profile motorola

redmi note 9
chime SDK profile xiaomi

Test environment Info:

  • Device: [motorola one action, redmi note 9]
  • OS: [Android 10, 11]
  • Version amazon-chime-sdk: [e.g. 0.14.0]
  • Version amazon-chime-sdk-media: [e.g. 0.14.0]
@VadimChubarov VadimChubarov changed the title oRenderVVideoFrameRGBABuffer implementation of VideoFrameBuffer (within VideoFrame) having issues with Videiew implementations RenderVideoFrameRGBABuffer implementation of VideoFrameBuffer (within VideoFrame) having issues with VideoRenderView implementations Jan 4, 2022
@VadimChubarov VadimChubarov changed the title RenderVideoFrameRGBABuffer implementation of VideoFrameBuffer (within VideoFrame) having issues with VideoRenderView implementations VideoFrameRGBABuffer implementation of VideoFrameBuffer (within VideoFrame) having issues with VideoRenderView implementations Jan 4, 2022
@linsang21
Copy link
Contributor

Hi @VadimChubarov I'm trying to reproduce the issue, and want to make sure how did you create the RGVABuffer. Because based on the previous issue, you mentioned create VideoFrame instance with VideoFrameRGBABuffer provided like constructor param, is this RGBABuffer created properly? Also, is this before or after a meeting session is started? Is this video frame sent with startLocalVideo?

@linsang21 linsang21 added the Needs More Information Further information is requested label Jan 5, 2022
@VadimChubarov
Copy link
Author

VadimChubarov commented Jan 6, 2022

Hi @linsang21 the problem manifests exactly with same scenario like in #344, practically when RGB frame passed to AudioVideoControllerFacade via startLocalVideo(source: VideoSource) within meeting session we are getting proper output picture by using VideoRenderView no any problems in this case. The problem happens when the same RGB frame passed directly to VideoRenderView via method onVideoFrameReceived (with other types of video frame it works fine)
As RGB frame recognized properly by VideoSourceAdapter by using AudioVideoControllerFacade most probably RGBABuffer should be valid (as well it works fine with our custom TextureView)

@ethanjanadrake
Copy link
Contributor

Hi @VadimChubarov,

Are you still experiencing this issue?

@hensmi-amazon
Copy link
Contributor

This may be related to #504

@ziyiz-amzn
Copy link
Contributor

@VadimChubarov Were you able to observe the memory issue on various of devices or some specific devices like Redmi?

@ziyiz-amzn
Copy link
Contributor

The fix has been released in the latest release 0.17.7. Please check and let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs More Information Further information is requested
Projects
None yet
Development

No branches or pull requests

6 participants