Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meetingV2 demo 'activeSpeakerLayout' field does nothing #1156

Closed
richnew10 opened this issue Mar 25, 2021 · 2 comments
Closed

meetingV2 demo 'activeSpeakerLayout' field does nothing #1156

richnew10 opened this issue Mar 25, 2021 · 2 comments
Labels
demo Demo bug or feature request if coupled with 'enhancement' label.

Comments

@richnew10
Copy link
Contributor

It should be possible to disable active speaker layout, or that field should be removed and appropriate cleanup done.
@p-foucht
Copy link
Contributor

Related to "demo code that does nothing" -- probably all instances of AsyncScheduler should be removed from the demo. AFAICT, they aren't adding any value while making the code look more complex to builders than is necessary

Piggybacking because I don't think this deserves its own ticket :D

@vidya-mohan vidya-mohan added the demo Demo bug or feature request if coupled with 'enhancement' label. label Jun 10, 2021
@xuesichao xuesichao mentioned this issue Nov 8, 2021
Merged
@xuesichao
Copy link
Contributor

Removed the activeSpeakerLayout field in the above PR. We can add it back when we have the logic. Close the Issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
demo Demo bug or feature request if coupled with 'enhancement' label.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@xuesichao @richnew10 @michhyun1 @vidya-mohan @p-foucht @devalevenkatesh