Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to migrate from legacy getStats() to standard getStats() in DefaultStatsController #1320

Closed
ldai1 opened this issue May 26, 2021 · 1 comment
Closed

Need to migrate from legacy getStats() to standard getStats() in DefaultStatsController #1320

ldai1 opened this issue May 26, 2021 · 1 comment
Assignees
@ldai1
Labels
feature-request New feature or request video Issues related to quality of the video stream - blurry, jerky, freezes, black screens or unable to s
Projects
Amazon Chime SDK Project Board

Comments

@ldai1
Copy link
Contributor

ldai1 commented May 26, 2021 •
edited
Loading

Important: Please attach INFO-level logs with timestamps to the report from before the session started up until the point at which the unexpected behavior occurred. For multi-participant calls, attach a log file for each participant if possible.

Describe the bug
Currently, the JS SDK StatsCollector collects webRTC legacy getStats() API for Chromium based browsers. There are three reasons to migrate to standard getStats() API:

  1. Simulcast is not supported by legacy stats. When we enable simulcast for chromium based browsers, local attendee should expect multiple SSRCs returned for their upstream video metrics. But with this legacy stats, only single upstream is returned.
  2. Legacy stats will be eventually deprecated. It is recommended by Google to migrate to using standard stats before its deprecation. Official doc: https://docs.google.com/document/d/1z-D4SngG36WPiMuRvWeTMN7mWQXrf1XKZwVl3Nf1BIE/edit
  3. To simplify our code base as well as avoid confusion for developers (See

    amazon-chime-sdk-js/demos/browser/app/meetingV2/meetingV2.ts

    Line 987 in 421aced

    typeof metricReport.availableSendBandwidth === 'number' &&
    where developers have to get different bandwidth metric name for the same bandwidth metric)
@ldai1 ldai1 added the feature-request New feature or request label May 26, 2021
@ldai1 ldai1 self-assigned this May 28, 2021
@vidya-mohan vidya-mohan added the video Issues related to quality of the video stream - blurry, jerky, freezes, black screens or unable to s label Jun 10, 2021
@vidya-mohan vidya-mohan added this to Tell Us What You Need in Amazon Chime SDK Project Board Jul 7, 2021
@awsvikas awsvikas moved this from Tell Us What You Need to Researching in Amazon Chime SDK Project Board Jul 14, 2021
@xuesichao xuesichao mentioned this issue Mar 8, 2022
Merged
@xuesichao
Copy link
Contributor

xuesichao commented Mar 11, 2022 •
edited
Loading

Close the issue as the fix will be released in v3.0.0-beta.1 soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ldai1 ldai1

Labels
feature-request New feature or request video Issues related to quality of the video stream - blurry, jerky, freezes, black screens or unable to s
Projects
Amazon Chime SDK Project Board
Researching
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ldai1 @xuesichao @vidya-mohan