Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test code structure #218

Open
SaxyPandaBear opened this issue May 10, 2023 · 1 comment
Open

Refactor test code structure #218

SaxyPandaBear opened this issue May 10, 2023 · 1 comment

Comments

@SaxyPandaBear
Copy link
Contributor

Currently, the test code layout is messy, with so many convoluted (and possibly circular) dependency directions for code execution. We should spend some time to clean up the codebase to make it easier to follow. My biggest concern is around the metric_value_benchmark test directory and everything in there. This is the biggest headache at the moment.

@khanhntd
Copy link
Contributor

One of the reasons why I used the validator to generalize as much as possible (e.g for metric value benchmark, you can use the following agent config with the following validator config to validate all the things from metric_value_benchmark) and we don't need to rely on specific test case anymore)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants