This repository has been archived by the owner on Sep 16, 2020. It is now read-only.
Fix some lint issues and add npm run build for UMD module
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jotto! I will bring up the pull request within the team in order to merge it. Weird that the callback in removeRecord was called in the body but not present in the function signature . |
|
gentle ping |
|
Hi, can you confirm that we can use, modify, copy, and redistribute this PR? Thank you! |
I confirm that this PR can be used, modified, copied, and redistributed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR began as a couple of lint fixes so I could copy and paste the minified code into an existing project without blowing up eslint.
Then, it seemed easy enough to just create a UMD module definition. All that's left now is to push to the npm registry.
There are no tests to run, but I verified most functionality works as a browser global and require/import.
import 'amazon-cognito-js';orrequire('amazon-cognito-js');(after they push to npmjs.org)grunt uglify, donpm run build(same command as amazon-cognito-identity-js)