Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename getStatus() and getStatusDuration() methods to getState() and getStateDuration(), respectively #95

Closed
wants to merge 4 commits into from

Conversation

aguecida
Copy link
Contributor

@aguecida aguecida commented Feb 28, 2019

Issue #, if available:

#37

Description of changes:

  • Renamed getStatus() and getStatusDuration() methods to getState() and getStateDuration(), respectively, so that it matches the methods as shown in the documentation (for both the Contact and Connection classes).
  • The methods can still be called using the old naming convention for backwards compatibility. This is equivalent to how agent.getStatus() and agent.getState() reference the same method.
  • Use the ContactStateType enum internally, as opposed to ContactStatusType
  • Updated the type definition file to match the new method names.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aguecida aguecida mentioned this pull request Mar 13, 2019
@h3adache
Copy link
Contributor

Thanks for the contribution @aguecida
The documentation was updated to reference both so I'm going to close this request.

@h3adache h3adache closed this Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants