Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compose default prefix (backward incompatible) #239

Closed
yinshiua opened this issue Apr 27, 2017 · 4 comments
Closed

Remove compose default prefix (backward incompatible) #239

yinshiua opened this issue Apr 27, 2017 · 4 comments

Comments

@yinshiua
Copy link
Contributor

ecs-cli compose up and ecs-cli compose service up appends a prefix (ecscompose- and ecscompose-service-) to the task definition name and service name. There were many complains about the added prefixes previously (issues: #51, #82, #91, #97), so we made the prefixes configurable in the config file. I would like to remove the prefixes completely from the config file and not append the prefix at all. This will be a backward incompatible change, so we would like your opinion on this.

The prefix is currently stored in ~/.ecs/config.

@samuelkarp
Copy link
Contributor

Would removing the prefix mean that ecs-cli could no longer manage existing clusters and services it launched when you upgrade it?

@yinshiua
Copy link
Contributor Author

For clusters, we are using the default cfn default prefix, so if you did not customize the cfn prefix, you can continue to manage existing clusters.

For services, you can add the prefix to the project name (ex. ecs-cli compose --project-name "ecscompose-service-<project_dir>" service scale) to manage existing services

@samuelkarp
Copy link
Contributor

I think the backwards incompatibility here is going to cause pain for people unexpectedly. If we're switching the default, there should be fallback logic to handle services that were created prior to this change.

@etsuo
Copy link

etsuo commented Oct 10, 2017

@yinshiua this is actually a bit of a bummer for us in that it now requires that we add yet another magic config file (~/.ecs/config) to get rid of the prefix. By itself, it's no biggie, but the less of these things we have, the easier it is for us to write scripts with no dependencies. Is there any way we could get an environmental variable to override the prefixes, or an argument?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants