SUSE systemd unit missing appropriate stop, post-stop directives

[jahkeup]

Summary

The SUSE systemd unit is missing the directives now present and accounted for in the AL2 systemd unit.

[fierlion]

https://github.com/aws/amazon-ecs-init/blob/master/packaging/suse/amazon-ecs.service

[fierlion]

We've got the stop and post-stop here:

https://github.com/aws/amazon-ecs-init/blob/master/packaging/amazon-linux-ami/ecs.service#L29-L30

I'll start by manually adding them to SUSE (the link above) then testing the service manually in an instance of the SUSE AMI (testing on SUSE Linux Enterprise Server 12 SP4 (HVM), SSD Volume Type and SUSE Linux Enterprise Server 15 SP1 (HVM), SSD Volume Type in us-west-2) Hoping the service will just work. If not, we'll learn what else needs to happen.

[jahkeup]

@fierlion not sure what's meant with these links, I think there's still differences present here though I'm somewhat removed from on going work in ecs-init at this point. From a quick glance, I do see that we're not calling the same subcommands that we're calling and using in AL2 (which was what this issue was opened to address). We should test/get-confirmations that the service works correctly and behaves similarly on OpenSUSE as it does in AL2.

[fierlion]

Sorry. See updates to my comment above.

[jahkeup]

Okay, I got it 👍

So the real outstanding task here is to actually go and test it before we commit that change (which I think was the reason why I deferred the effort to an issue long, long ago..), is that right?

[samuelkarp]

https://build.opensuse.org/package/show/openSUSE:Factory/amazon-ecs-init appears to be the place where the OpenSUSE build is produced. @rjschwei is the maintainer who had been helping us package ecs-init for that distro.

[fierlion]

So the real outstanding task here is to actually go and test it before we commit that change (which I think was the reason why I deferred the effort to an issue long, long ago..), is that right?

that's right. I'll update here with my manual test results on SUSE.

[fierlion]

#285
see the above for detail on my testing done

[rjschwei]

https://build.opensuse.org/package/show/openSUSE:Factory/amazon-ecs-init is the derived package for release with openSUSE Tumbleweed which will eventually make it's way into openSUSE Leap and SLE. Development of the package happens here:

https://build.opensuse.org/package/show/Cloud:Tools/amazon-ecs-init

[fierlion]

Merged. I'll open a follow-up issue to work through the make rpm target and the suse spec file. make rpm is pinned to amazon-linux and the suse spec file hasn't been updated in a while and requires attention.