Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove postgres-only code #173

Open
dataders opened this issue Jul 7, 2023 · 1 comment · May be fixed by #174
Open

remove postgres-only code #173

dataders opened this issue Jul 7, 2023 · 1 comment · May be fixed by #174

Comments

@dataders
Copy link

dataders commented Jul 7, 2023

when querying pg_views, redshift coerces materialized views to be of relkind='v', so the below case statement is not relevant to Redshift at all. I wish that Redshift wouldn't do this, but I'll take as a consolation prize that the redshift python connector not have coded references to relkind='m'

amazon-redshift-python-driver/redshift_connector/cursor.py

Line 927 in b2dde82

" WHEN 'm' THEN 'MATERIALIZED VIEW' "

@dataders dataders linked a pull request Jul 7, 2023 that will close this issue
Open
8 tasks
@Brooke-white
Copy link
Contributor

Hi @dataders , thank you for taking the time to open this issue as well as the associated pull request. Given we align these metadata queries across all of our Redshift drivers, we will need to discuss this with the Redshift team before making any changes.

If you can please provide the following information to aid our team's discussion of this issue:

  • What impact is seen by this case statement's presence?
  • Which version of Redshift server was in use when this was discovered?

I'll post updates here as they become available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove postgres-specific reference to pg_views.relkind='m' dataders/amazon-redshift-python-driver
2 participants
@Brooke-white @dataders