-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Multus Thick Client to make vpc-cni mandatory instead of keeping auto #2767
Comments
Thanks @raghs-aws, we are open to taking a PR to update the manifest. In general, though, customers need to be conscious of components that install unwanted CNIs, as those components can cause other issues. |
I was able to spare sometime to look into this and below tests to mimic the resoulution Test1:
Test 2:
Multus functionality was also validated after Test 1 by testing the solution https://github.com/aws-samples/eks-automated-ipmgmt-multus-pods |
Thanks for testing @raghs-aws! Feel free to open a PR to update the manifest and we can merge it |
Closing now that #2828 has merged |
This issue is now closed. Comments on closed issues are hard for our team to see. |
What would you like to be added:
Thick plugin doesn't set the master cni or the default cni, and keeps "multusConfigFile": "auto". This causes Multus to pick other cnis than vpc-cni in some cases , if we have some cni installed like istio-cni.
Recommendation is to not generate the multus-conf file dynamically, but always have
"clusterNetwork": "/etc/cni/net.d/10-aws.conflist",
ex: https://github.com/k8snetworkplumbingwg/multus-cni/blob/master/docs/configuration.md
Why is this needed:
Since this release is only for AWS VPC CNI and Multus with vpc-cni, Multus should be released with vpc cni configuration as the master/default cni.
In Multus thin plugin, the release has "--multus-master-cni-file-name=10-aws.conflist" alongwith --multus-conf-file=auto (reference https://github.com/aws/amazon-vpc-cni-k8s/blob/master/config/multus/v3.9.2-eksbuild.1/aws-k8s-multus.yaml).
The text was updated successfully, but these errors were encountered: