fix(integration tests): CircleCI workflows and Cypress integration testing #1071
Conversation
… into cypress-workflows
… into cypress-workflows
mlabieniec
changed the title
… into cypress-workflows
… into cypress-workflows
… into cypress-workflows
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "baseUrl": "http://localhost:3000/", | |||
| "video": false | |||
There was a problem hiding this comment.
do we have the ability to create these and push them somewhere? Perhaps to S3 etc. This would be useful to see if any issues arise (eventually).
There was a problem hiding this comment.
In that case should be a unique prefix, in case there are concurrent pr's
There was a problem hiding this comment.
After a little research I found that you can upload artifacts with CircleCI:
https://circleci.com/docs/2.0/artifacts/
looks like I can do this right in the circleci config:
https://github.com/cypress-io/cypress-example-docker-circle#artifacts
I can do this for now and we can create a task to look into uploading to an s3 bucket.
There was a problem hiding this comment.
Looks good, I just want to confirm the publishing to @latest , see comment
.circleci/config.yml
Outdated
| git clone $AUTH_CLONE_URL | ||
| cd aws-amplify-cypress-auth | ||
| yarn | ||
| awsmobile configure aws $IAM_ACCESS_KEY $IAM_SECRET_KEY us-east-1 |
There was a problem hiding this comment.
Should the region be a env variable too?
There was a problem hiding this comment.
Good call. I can make it an env variable.
.circleci/config.yml
Outdated
| filters: | ||
| branches: | ||
| only: | ||
| - master |
There was a problem hiding this comment.
Should this happen on the release branch too? How are we going to publish to @latest ?
There was a problem hiding this comment.
Good call. I can add the release branch here. Are there any other branches we should consider here?
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "baseUrl": "http://localhost:3000/", | |||
There was a problem hiding this comment.
Can we assume that the test will run only on one container? So yarn start wont block port 3000...
There was a problem hiding this comment.
This baseUrl is the url that the cloned test package will run on. Parallel integration tests will run on separate containers, so there should be no blocking, however there would be blocking on the same container. Is this a problem? I may be confused with what you are asking.
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Description of changes:
CircleCI changes
Cypress Integration
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.