Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query string for non signed requests #801

Merged
merged 5 commits into from
Jun 4, 2018

Conversation

elorzafe
Copy link
Contributor

@elorzafe elorzafe commented May 8, 2018

Issue #, if available:
Fixes: #361
Fixes: #127
Description of changes:
Query string fix for non signed requests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented May 8, 2018

Codecov Report

Merging #801 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #801   +/-   ##
=======================================
  Coverage   87.34%   87.34%           
=======================================
  Files          79       79           
  Lines        3831     3831           
  Branches      704      704           
=======================================
  Hits         3346     3346           
  Misses        462      462           
  Partials       23       23
Impacted Files Coverage Δ
packages/aws-amplify/src/API/RestClient.ts 92.78% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dad34c...1b129c2. Read the comment docs.

Copy link
Contributor

@manueliglesias manueliglesias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@elorzafe elorzafe merged commit 6746368 into aws-amplify:master Jun 4, 2018
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

escape characters in URI Cannot get API.get to work
3 participants