fix(Storage): allowing to set an empty value as prefix for the S3 Key #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #931 +/- ##
=========================================
Coverage ? 87.48%
=========================================
Files ? 78
Lines ? 3707
Branches ? 684
=========================================
Hits ? 3243
Misses ? 441
Partials ? 23
Continue to review full report at Codecov.
|
MrIceman
force-pushed
the
feature/s3-prefix-fix
branch
from
8fec4d1
to
81e3937
Compare
|
I have added unit tests. It seems like there are many more tests missing for Storage.ts |
mlabieniec
changed the title
mlabieniec
changed the title
This was referenced Dec 1, 2020
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #853
Description of changes:
Old implementation does not allow to have NO prefix for requested S3 Resource-Keys at all. When setting customPrefix{public: ''} the customPrefix is being set to 'public/', however the prefix should be an empty string
const x = '' || 'something else'; is equivalent to const y = undefined || 'something else';
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.