/
resource_manager.go
352 lines (322 loc) · 13.4 KB
/
resource_manager.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
package virtualservice
import (
"context"
appmesh "github.com/aws/aws-app-mesh-controller-for-k8s/apis/appmesh/v1beta2"
"github.com/aws/aws-app-mesh-controller-for-k8s/pkg/aws/services"
"github.com/aws/aws-app-mesh-controller-for-k8s/pkg/conversions"
"github.com/aws/aws-app-mesh-controller-for-k8s/pkg/k8s"
"github.com/aws/aws-app-mesh-controller-for-k8s/pkg/mesh"
"github.com/aws/aws-app-mesh-controller-for-k8s/pkg/references"
"github.com/aws/aws-app-mesh-controller-for-k8s/pkg/runtime"
"github.com/aws/aws-app-mesh-controller-for-k8s/pkg/virtualnode"
"github.com/aws/aws-app-mesh-controller-for-k8s/pkg/virtualrouter"
"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/aws/awserr"
appmeshsdk "github.com/aws/aws-sdk-go/service/appmesh"
"github.com/go-logr/logr"
"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
"github.com/pkg/errors"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/conversion"
"k8s.io/apimachinery/pkg/types"
"sigs.k8s.io/controller-runtime/pkg/client"
)
// ResourceManager is dedicated to manage AppMesh VirtualService resources for k8s VirtualService CRs.
type ResourceManager interface {
// Reconcile will create/update AppMesh VirtualService to match vs.spec, and update vs.status
Reconcile(ctx context.Context, vs *appmesh.VirtualService) error
// Cleanup will delete AppMesh VirtualService created for vs.
Cleanup(ctx context.Context, vs *appmesh.VirtualService) error
}
func NewDefaultResourceManager(
k8sClient client.Client,
appMeshSDK services.AppMesh,
referencesResolver references.Resolver,
accountID string,
log logr.Logger) ResourceManager {
return &defaultResourceManager{
k8sClient: k8sClient,
appMeshSDK: appMeshSDK,
referencesResolver: referencesResolver,
accountID: accountID,
log: log,
}
}
type defaultResourceManager struct {
k8sClient client.Client
appMeshSDK services.AppMesh
referencesResolver references.Resolver
accountID string
log logr.Logger
}
func (m *defaultResourceManager) Reconcile(ctx context.Context, vs *appmesh.VirtualService) error {
ms, err := m.findMeshDependency(ctx, vs)
if err != nil {
return err
}
if err := m.validateMeshDependencies(ctx, ms); err != nil {
return err
}
vnByKey, err := m.findVirtualNodeDependencies(ctx, vs)
if err != nil {
return err
}
if err := m.validateVirtualNodeDependencies(ctx, ms, vnByKey); err != nil {
return err
}
vrByKey, err := m.findVirtualRouterDependencies(ctx, vs)
if err != nil {
return err
}
if err := m.validateVirtualRouterDependencies(ctx, ms, vrByKey); err != nil {
return err
}
sdkVS, err := m.findSDKVirtualService(ctx, ms, vs)
if err != nil {
return err
}
if sdkVS == nil {
sdkVS, err = m.createSDKVirtualService(ctx, ms, vs, vnByKey, vrByKey)
if err != nil {
return err
}
} else {
sdkVS, err = m.updateSDKVirtualService(ctx, sdkVS, vs, vnByKey, vrByKey)
if err != nil {
return err
}
}
return m.updateCRDVirtualService(ctx, vs, sdkVS)
}
func (m *defaultResourceManager) Cleanup(ctx context.Context, vs *appmesh.VirtualService) error {
ms, err := m.findMeshDependency(ctx, vs)
if err != nil {
return err
}
sdkVS, err := m.findSDKVirtualService(ctx, ms, vs)
if err != nil {
if vs.Status.VirtualServiceARN == nil {
return nil
}
return err
}
if sdkVS == nil {
return nil
}
return m.deleteSDKVirtualService(ctx, sdkVS, vs)
}
// findMeshDependency find the Mesh dependency for this VirtualService.
func (m *defaultResourceManager) findMeshDependency(ctx context.Context, vs *appmesh.VirtualService) (*appmesh.Mesh, error) {
if vs.Spec.MeshRef == nil {
return nil, errors.Errorf("meshRef shouldn't be nil, please check webhook setup")
}
ms, err := m.referencesResolver.ResolveMeshReference(ctx, *vs.Spec.MeshRef)
if err != nil {
return nil, errors.Wrapf(err, "failed to resolve meshRef")
}
return ms, nil
}
// validateMeshDependencies validate the Mesh dependency for this VirtualService.
func (m *defaultResourceManager) validateMeshDependencies(ctx context.Context, ms *appmesh.Mesh) error {
if !mesh.IsMeshActive(ms) {
return runtime.NewRequeueError(errors.New("mesh is not active yet"))
}
return nil
}
func (m *defaultResourceManager) findVirtualNodeDependencies(ctx context.Context, vs *appmesh.VirtualService) (map[types.NamespacedName]*appmesh.VirtualNode, error) {
vnRefs := ExtractVirtualNodeReferences(vs)
vnByKey := make(map[types.NamespacedName]*appmesh.VirtualNode)
for _, vnRef := range vnRefs {
vnKey := references.ObjectKeyForVirtualNodeReference(vs, vnRef)
if _, ok := vnByKey[vnKey]; ok {
continue
}
vn, err := m.referencesResolver.ResolveVirtualNodeReference(ctx, vs, vnRef)
if err != nil {
return nil, errors.Wrapf(err, "failed to resolve virtualNodeRef")
}
vnByKey[vnKey] = vn
}
return vnByKey, nil
}
func (m *defaultResourceManager) validateVirtualNodeDependencies(ctx context.Context, ms *appmesh.Mesh, vnByKey map[types.NamespacedName]*appmesh.VirtualNode) error {
for _, vn := range vnByKey {
if vn.Spec.MeshRef == nil || !mesh.IsMeshReferenced(ms, *vn.Spec.MeshRef) {
return errors.Errorf("virtualNode %v didn't belong to mesh %v", k8s.NamespacedName(vn), k8s.NamespacedName(ms))
}
if !virtualnode.IsVirtualNodeActive(vn) {
return runtime.NewRequeueError(errors.New("virtualNode is not active yet"))
}
}
return nil
}
func (m *defaultResourceManager) findVirtualRouterDependencies(ctx context.Context, vs *appmesh.VirtualService) (map[types.NamespacedName]*appmesh.VirtualRouter, error) {
vrRefs := ExtractVirtualRouterReferences(vs)
vrByKey := make(map[types.NamespacedName]*appmesh.VirtualRouter)
for _, vrRef := range vrRefs {
vrKey := references.ObjectKeyForVirtualRouterReference(vs, vrRef)
if _, ok := vrByKey[vrKey]; ok {
continue
}
vr, err := m.referencesResolver.ResolveVirtualRouterReference(ctx, vs, vrRef)
if err != nil {
return nil, errors.Wrapf(err, "failed to resolve virtualRouterRef")
}
vrByKey[vrKey] = vr
}
return vrByKey, nil
}
func (m *defaultResourceManager) validateVirtualRouterDependencies(ctx context.Context, ms *appmesh.Mesh, vrByKey map[types.NamespacedName]*appmesh.VirtualRouter) error {
for _, vr := range vrByKey {
if vr.Spec.MeshRef == nil || !mesh.IsMeshReferenced(ms, *vr.Spec.MeshRef) {
return errors.Errorf("virtualRouter %v didn't belong to mesh %v", k8s.NamespacedName(vr), k8s.NamespacedName(ms))
}
if !virtualrouter.IsVirtualRouterActive(vr) {
return runtime.NewRequeueError(errors.New("virtualRouter is not active yet"))
}
}
return nil
}
func (m *defaultResourceManager) findSDKVirtualService(ctx context.Context, ms *appmesh.Mesh, vs *appmesh.VirtualService) (*appmeshsdk.VirtualServiceData, error) {
resp, err := m.appMeshSDK.DescribeVirtualServiceWithContext(ctx, &appmeshsdk.DescribeVirtualServiceInput{
MeshName: ms.Spec.AWSName,
MeshOwner: ms.Spec.MeshOwner,
VirtualServiceName: vs.Spec.AWSName,
})
if err != nil {
if awsErr, ok := err.(awserr.Error); ok && awsErr.Code() == "NotFoundException" {
return nil, nil
}
return nil, err
}
return resp.VirtualService, nil
}
func (m *defaultResourceManager) createSDKVirtualService(ctx context.Context, ms *appmesh.Mesh, vs *appmesh.VirtualService,
vnByKey map[types.NamespacedName]*appmesh.VirtualNode, vrByKey map[types.NamespacedName]*appmesh.VirtualRouter) (*appmeshsdk.VirtualServiceData, error) {
sdkVSSpec, err := BuildSDKVirtualServiceSpec(vs, vnByKey, vrByKey)
if err != nil {
return nil, err
}
resp, err := m.appMeshSDK.CreateVirtualServiceWithContext(ctx, &appmeshsdk.CreateVirtualServiceInput{
MeshName: ms.Spec.AWSName,
MeshOwner: ms.Spec.MeshOwner,
VirtualServiceName: vs.Spec.AWSName,
Spec: sdkVSSpec,
})
if err != nil {
return nil, err
}
return resp.VirtualService, nil
}
func (m *defaultResourceManager) updateSDKVirtualService(ctx context.Context, sdkVS *appmeshsdk.VirtualServiceData, vs *appmesh.VirtualService,
vnByKey map[types.NamespacedName]*appmesh.VirtualNode, vrByKey map[types.NamespacedName]*appmesh.VirtualRouter) (*appmeshsdk.VirtualServiceData, error) {
actualSDKVSSpec := sdkVS.Spec
desiredSDKVSSpec, err := BuildSDKVirtualServiceSpec(vs, vnByKey, vrByKey)
if err != nil {
return nil, err
}
opts := cmpopts.EquateEmpty()
if cmp.Equal(desiredSDKVSSpec, actualSDKVSSpec, opts) {
return sdkVS, nil
}
if !m.isSDKVirtualServiceControlledByCRDVirtualService(ctx, sdkVS, vs) {
m.log.V(1).Info("skip virtualService update since it's not controlled",
"virtualService", k8s.NamespacedName(vs),
"virtualServiceARN", aws.StringValue(sdkVS.Metadata.Arn),
)
return sdkVS, nil
}
diff := cmp.Diff(desiredSDKVSSpec, actualSDKVSSpec, opts)
m.log.V(1).Info("virtualServiceSpec changed",
"virtualService", k8s.NamespacedName(vs),
"actualSDKVRSpec", actualSDKVSSpec,
"desiredSDKVRSpec", desiredSDKVSSpec,
"diff", diff,
)
resp, err := m.appMeshSDK.UpdateVirtualServiceWithContext(ctx, &appmeshsdk.UpdateVirtualServiceInput{
MeshName: sdkVS.MeshName,
MeshOwner: sdkVS.Metadata.MeshOwner,
VirtualServiceName: sdkVS.VirtualServiceName,
Spec: desiredSDKVSSpec,
})
if err != nil {
return nil, err
}
return resp.VirtualService, nil
}
func (m *defaultResourceManager) deleteSDKVirtualService(ctx context.Context, sdkVS *appmeshsdk.VirtualServiceData, vs *appmesh.VirtualService) error {
if !m.isSDKVirtualServiceOwnedByCRDVirtualService(ctx, sdkVS, vs) {
m.log.V(1).Info("skip virtualService deletion since its not owned",
"virtualService", k8s.NamespacedName(vs),
"virtualServiceARN", aws.StringValue(sdkVS.Metadata.Arn),
)
return nil
}
_, err := m.appMeshSDK.DeleteVirtualServiceWithContext(ctx, &appmeshsdk.DeleteVirtualServiceInput{
MeshName: sdkVS.MeshName,
MeshOwner: sdkVS.Metadata.MeshOwner,
VirtualServiceName: sdkVS.VirtualServiceName,
})
if err != nil {
return err
}
return nil
}
func (m *defaultResourceManager) updateCRDVirtualService(ctx context.Context, vs *appmesh.VirtualService, sdkVS *appmeshsdk.VirtualServiceData) error {
oldVS := vs.DeepCopy()
needsUpdate := false
if aws.StringValue(vs.Status.VirtualServiceARN) != aws.StringValue(sdkVS.Metadata.Arn) {
vs.Status.VirtualServiceARN = sdkVS.Metadata.Arn
needsUpdate = true
}
if aws.Int64Value(vs.Status.ObservedGeneration) != vs.Generation {
vs.Status.ObservedGeneration = aws.Int64(vs.Generation)
needsUpdate = true
}
vsActiveConditionStatus := corev1.ConditionFalse
if sdkVS.Status != nil && aws.StringValue(sdkVS.Status.Status) == appmeshsdk.VirtualServiceStatusCodeActive {
vsActiveConditionStatus = corev1.ConditionTrue
}
if updateCondition(vs, appmesh.VirtualServiceActive, vsActiveConditionStatus, nil, nil) {
needsUpdate = true
}
if !needsUpdate {
return nil
}
return m.k8sClient.Status().Patch(ctx, vs, client.MergeFrom(oldVS))
}
// isSDKVirtualServiceControlledByCRDVirtualService checks whether an AppMesh VirtualService is controlled by CRD VirtualService.
// if it's controlled, CRD VirtualService update is responsible for updating the AppMesh VirtualService.
func (m *defaultResourceManager) isSDKVirtualServiceControlledByCRDVirtualService(ctx context.Context, sdkVS *appmeshsdk.VirtualServiceData, vs *appmesh.VirtualService) bool {
return aws.StringValue(sdkVS.Metadata.ResourceOwner) == m.accountID
}
// isSDKVirtualServiceOwnedByCRDVirtualService checks whether an AppMesh VirtualService is owned by CRD VirtualService.
// if it's owned, CRD VirtualService deletion is responsible for deleting the AppMesh VirtualService.
func (m *defaultResourceManager) isSDKVirtualServiceOwnedByCRDVirtualService(ctx context.Context, sdkVS *appmeshsdk.VirtualServiceData, vs *appmesh.VirtualService) bool {
if !m.isSDKVirtualServiceControlledByCRDVirtualService(ctx, sdkVS, vs) {
return false
}
// TODO: Adding tagging support, so a existing virtualService in owner account but not ownership can be support.
// currently, virtualService controllership == ownership, but it don't have to be so once we add tagging support.
return true
}
func BuildSDKVirtualServiceSpec(vs *appmesh.VirtualService, vnByKey map[types.NamespacedName]*appmesh.VirtualNode, vrByKey map[types.NamespacedName]*appmesh.VirtualRouter) (*appmeshsdk.VirtualServiceSpec, error) {
converter := conversion.NewConverter(conversion.DefaultNameFunc)
converter.RegisterUntypedConversionFunc((*appmesh.VirtualServiceSpec)(nil), (*appmeshsdk.VirtualServiceSpec)(nil), func(a, b interface{}, scope conversion.Scope) error {
return conversions.Convert_CRD_VirtualServiceSpec_To_SDK_VirtualServiceSpec(a.(*appmesh.VirtualServiceSpec), b.(*appmeshsdk.VirtualServiceSpec), scope)
})
sdkVNRefConvertFunc := references.BuildSDKVirtualNodeReferenceConvertFunc(vs, vnByKey)
converter.RegisterUntypedConversionFunc((*appmesh.VirtualNodeReference)(nil), (*string)(nil), func(a, b interface{}, scope conversion.Scope) error {
return sdkVNRefConvertFunc(a.(*appmesh.VirtualNodeReference), b.(*string), scope)
})
sdkVRRefConvertFunc := references.BuildSDKVirtualRouterReferenceConvertFunc(vs, vrByKey)
converter.RegisterUntypedConversionFunc((*appmesh.VirtualRouterReference)(nil), (*string)(nil), func(a, b interface{}, scope conversion.Scope) error {
return sdkVRRefConvertFunc(a.(*appmesh.VirtualRouterReference), b.(*string), scope)
})
sdkVSSpec := &appmeshsdk.VirtualServiceSpec{}
if err := converter.Convert(&vs.Spec, sdkVSSpec, nil); err != nil {
return nil, err
}
return sdkVSSpec, nil
}