-
Notifications
You must be signed in to change notification settings - Fork 111
/
manager.go
371 lines (331 loc) · 14.4 KB
/
manager.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
package virtualnode
import (
"context"
"errors"
"fmt"
awssdk "github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/service/servicediscovery"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"strconv"
"time"
appmesh "github.com/aws/aws-app-mesh-controller-for-k8s/apis/appmesh/v1beta2"
"github.com/aws/aws-app-mesh-controller-for-k8s/pkg/aws/services"
"github.com/aws/aws-app-mesh-controller-for-k8s/pkg/cloudmap"
"github.com/aws/aws-app-mesh-controller-for-k8s/pkg/equality"
"github.com/aws/aws-app-mesh-controller-for-k8s/pkg/references"
"github.com/aws/aws-app-mesh-controller-for-k8s/pkg/virtualnode"
"github.com/aws/aws-app-mesh-controller-for-k8s/test/framework/k8s"
"github.com/aws/aws-app-mesh-controller-for-k8s/test/framework/utils"
appmeshsdk "github.com/aws/aws-sdk-go/service/appmesh"
"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
corev1 "k8s.io/api/core/v1"
apierrs "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/types"
"k8s.io/apimachinery/pkg/util/wait"
"sigs.k8s.io/controller-runtime/pkg/client"
)
type Manager interface {
WaitUntilVirtualNodeActive(ctx context.Context, vn *appmesh.VirtualNode) (*appmesh.VirtualNode, error)
WaitUntilVirtualNodeDeleted(ctx context.Context, vn *appmesh.VirtualNode) error
CheckVirtualNodeInAWS(ctx context.Context, ms *appmesh.Mesh, vn *appmesh.VirtualNode) error
CheckVirtualNodeInCloudMap(ctx context.Context, ms *appmesh.Mesh, vn *appmesh.VirtualNode, ipFamily string) error
CheckVirtualNodeInCloudMapWithExpectedRegisteredPods(ctx context.Context, ms *appmesh.Mesh, vn *appmesh.VirtualNode, expectedRegisteredPods []*corev1.Pod) error
ValidateVirtualNodeBackends(ctx context.Context, ms *appmesh.Mesh, vn *appmesh.VirtualNode, expectedBackends []types.NamespacedName) error
}
func NewManager(k8sClient client.Client, appMeshSDK services.AppMesh, cloudMapSDK services.CloudMap, ipFamily string) Manager {
return &defaultManager{
k8sClient: k8sClient,
appMeshSDK: appMeshSDK,
cloudMapSDK: cloudMapSDK,
ipFamily: ipFamily,
}
}
type defaultManager struct {
k8sClient client.Client
appMeshSDK services.AppMesh
cloudMapSDK services.CloudMap
ipFamily string
}
func (m *defaultManager) WaitUntilVirtualNodeActive(ctx context.Context, vn *appmesh.VirtualNode) (*appmesh.VirtualNode, error) {
observedVN := &appmesh.VirtualNode{}
return observedVN, wait.PollImmediateUntil(utils.PollIntervalShort, func() (bool, error) {
// sometimes there's a delay in the resource showing up
for i := 0; i < 5; i++ {
if err := m.k8sClient.Get(ctx, k8s.NamespacedName(vn), observedVN); err != nil {
if i >= 5 {
return false, err
}
}
time.Sleep(100 * time.Millisecond)
}
for _, condition := range observedVN.Status.Conditions {
if condition.Type == appmesh.VirtualNodeActive && condition.Status == corev1.ConditionTrue {
return true, nil
}
}
return false, nil
}, ctx.Done())
}
func (m *defaultManager) WaitUntilVirtualNodeDeleted(ctx context.Context, vn *appmesh.VirtualNode) error {
observedVN := &appmesh.VirtualNode{}
return wait.PollImmediateUntil(utils.PollIntervalShort, func() (bool, error) {
if err := m.k8sClient.Get(ctx, k8s.NamespacedName(vn), observedVN); err != nil {
if apierrs.IsNotFound(err) {
return true, nil
}
return false, err
}
return false, nil
}, ctx.Done())
}
func (m *defaultManager) CheckVirtualNodeInAWS(ctx context.Context, ms *appmesh.Mesh, vn *appmesh.VirtualNode) error {
// TODO: handle aws throttling
vsByKey := make(map[types.NamespacedName]*appmesh.VirtualService)
vsRefs := virtualnode.ExtractVirtualServiceReferences(vn)
for _, vsRef := range vsRefs {
vs := &appmesh.VirtualService{}
if err := m.k8sClient.Get(ctx, references.ObjectKeyForVirtualServiceReference(vn, vsRef), vs); err != nil {
return err
}
vsByKey[k8s.NamespacedName(vs)] = vs
}
desiredSDKVNSpec, err := virtualnode.BuildSDKVirtualNodeSpec(vn, vsByKey)
if err != nil {
return err
}
resp, err := m.appMeshSDK.DescribeVirtualNodeWithContext(ctx, &appmeshsdk.DescribeVirtualNodeInput{
MeshName: ms.Spec.AWSName,
MeshOwner: ms.Spec.MeshOwner,
VirtualNodeName: vn.Spec.AWSName,
})
if err != nil {
return err
}
opts := equality.CompareOptionForVirtualNodeSpec()
if !cmp.Equal(desiredSDKVNSpec, resp.VirtualNode.Spec, opts) {
return errors.New(cmp.Diff(desiredSDKVNSpec, resp.VirtualNode.Spec, opts))
}
if vn.Spec.ServiceDiscovery.AWSCloudMap != nil {
if err := m.CheckVirtualNodeInCloudMap(ctx, ms, vn, m.ipFamily); err != nil {
return err
}
}
return nil
}
func (m *defaultManager) ValidateVirtualNodeBackends(ctx context.Context, ms *appmesh.Mesh, vn *appmesh.VirtualNode, expectedBackends []types.NamespacedName) error {
retryCount := 0
err := wait.PollImmediateUntil(utils.PollIntervalShort, func() (bool, error) {
err := m.checkVirtualNodeBackends(ctx, ms, vn, expectedBackends)
if err != nil {
if retryCount >= utils.PollRetries {
return false, err
}
retryCount++
return false, nil
}
return true, nil
}, ctx.Done())
return err
}
func (m *defaultManager) checkVirtualNodeBackends(ctx context.Context, ms *appmesh.Mesh, vn *appmesh.VirtualNode, expectedBackends []types.NamespacedName) error {
vsByKey := make(map[types.NamespacedName]*appmesh.VirtualService)
for _, backend := range expectedBackends {
vsRef := appmesh.VirtualServiceReference{
Namespace: &backend.Namespace,
Name: backend.Name,
}
vs := &appmesh.VirtualService{}
if err := m.k8sClient.Get(ctx, references.ObjectKeyForVirtualServiceReference(vn, vsRef), vs); err != nil {
return err
}
vsByKey[k8s.NamespacedName(vs)] = vs
}
desiredSDKVNSpec, err := virtualnode.BuildSDKVirtualNodeSpec(vn, vsByKey)
if err != nil {
return err
}
resp, err := m.appMeshSDK.DescribeVirtualNodeWithContext(ctx, &appmeshsdk.DescribeVirtualNodeInput{
MeshName: ms.Spec.AWSName,
MeshOwner: ms.Spec.MeshOwner,
VirtualNodeName: vn.Spec.AWSName,
})
if err != nil {
return err
}
less := func(a, b *appmeshsdk.Backend) bool {
return *a.VirtualService.VirtualServiceName < *b.VirtualService.VirtualServiceName
}
if cmp.Equal(desiredSDKVNSpec.Backends, resp.VirtualNode.Spec.Backends, cmpopts.SortSlices(less)) {
return nil
}
return errors.New(cmp.Diff(desiredSDKVNSpec.Backends, resp.VirtualNode.Spec.Backends, cmpopts.SortSlices(less)))
}
func (m *defaultManager) CheckVirtualNodeInCloudMap(ctx context.Context, ms *appmesh.Mesh, vn *appmesh.VirtualNode, ipFamily string) error {
//Get Pods that the VirtualNode selects on
var podsList corev1.PodList
var listOptions client.ListOptions
listOptions.LabelSelector, _ = metav1.LabelSelectorAsSelector(vn.Spec.PodSelector)
listOptions.Namespace = vn.Namespace
if err := m.k8sClient.List(ctx, &podsList, &listOptions); err != nil {
return err
}
instanceCount := len(podsList.Items)
localInstanceInfoMap := make(map[string]map[string]string, instanceCount)
for i := range podsList.Items {
pod := &podsList.Items[i]
instanceAttributeMap := make(map[string]string)
if ipFamily == utils.IPv6 {
instanceAttributeMap[cloudmap.AttrAWSInstanceIPV6] = pod.Status.PodIP
} else {
instanceAttributeMap[cloudmap.AttrAWSInstanceIPV4] = pod.Status.PodIP
}
instanceAttributeMap[cloudmap.AttrK8sPod] = pod.Name
instanceAttributeMap[cloudmap.AttrK8sNamespace] = pod.Namespace
instanceAttributeMap[cloudmap.AttrAppMeshMesh] = awssdk.StringValue(ms.Spec.AWSName)
instanceAttributeMap[cloudmap.AttrAppMeshVirtualNode] = awssdk.StringValue(vn.Spec.AWSName)
instanceAttributeMap[cloudmap.AttrAWSInstancePort] = strconv.Itoa(int(vn.Spec.Listeners[0].PortMapping.Port))
localInstanceInfoMap[pod.Status.PodIP] = instanceAttributeMap
}
return m.checkVirtualNodeInCloudMapWithExpectedRegistrations(ctx, vn, localInstanceInfoMap, ipFamily)
}
func (m *defaultManager) CheckVirtualNodeInCloudMapWithExpectedRegisteredPods(ctx context.Context, ms *appmesh.Mesh, vn *appmesh.VirtualNode, expectedRegisteredPods []*corev1.Pod) error {
expectedRegistrationInfo, err := m.loadExpectedRegistrationInfo(ctx, ms, vn, expectedRegisteredPods)
if err != nil {
return err
}
return m.checkVirtualNodeInCloudMapWithExpectedRegistrations(ctx, vn, expectedRegistrationInfo, m.ipFamily)
}
func (m *defaultManager) checkVirtualNodeInCloudMapWithExpectedRegistrations(ctx context.Context, vn *appmesh.VirtualNode, localInstanceInfoMap map[string]map[string]string, ipFamily string) error {
cloudMapConfig := vn.Spec.ServiceDiscovery.AWSCloudMap
//Get CloudMap Namespace Info
listNamespacesInput := &servicediscovery.ListNamespacesInput{}
var nsSummary *servicediscovery.NamespaceSummary
if err := m.cloudMapSDK.ListNamespacesPagesWithContext(ctx, listNamespacesInput,
func(listNamespacesOutput *servicediscovery.ListNamespacesOutput, lastPage bool) bool {
for _, ns := range listNamespacesOutput.Namespaces {
if awssdk.StringValue(ns.Name) == cloudMapConfig.NamespaceName {
nsSummary = ns
return false
}
}
return true
},
); err != nil {
return err
}
if nsSummary == nil {
return fmt.Errorf("failed to find namespace '%s'", cloudMapConfig.NamespaceName)
}
//Get ServiceInfo from CloudMap
listServicesInput := &servicediscovery.ListServicesInput{
Filters: []*servicediscovery.ServiceFilter{
{
Name: awssdk.String(servicediscovery.ServiceFilterNameNamespaceId),
Values: []*string{nsSummary.Id},
},
},
}
var sdkSVCSummary *servicediscovery.ServiceSummary
if err := m.cloudMapSDK.ListServicesPagesWithContext(ctx, listServicesInput,
func(listServicesOutput *servicediscovery.ListServicesOutput, lastPage bool) bool {
for _, svc := range listServicesOutput.Services {
if awssdk.StringValue(svc.Name) == cloudMapConfig.ServiceName {
sdkSVCSummary = svc
return false
}
}
return true
},
); err != nil {
return err
}
if sdkSVCSummary == nil {
return fmt.Errorf("failed to find service summary for '%s'", cloudMapConfig.ServiceName)
}
listInstancesInput := &servicediscovery.ListInstancesInput{
ServiceId: sdkSVCSummary.Id,
}
expectedInstanceCount := len(localInstanceInfoMap)
//Get Instance info
cloudMapInstanceInfoMap := make(map[string]map[string]string, expectedInstanceCount)
if err := m.cloudMapSDK.ListInstancesPagesWithContext(ctx, listInstancesInput,
func(listInstancesOutput *servicediscovery.ListInstancesOutput, lastPage bool) bool {
for _, instance := range listInstancesOutput.Instances {
cloudMapInstanceAttributes := make(map[string]string)
if ipFamily == utils.IPv6 {
cloudMapInstanceAttributes[cloudmap.AttrAWSInstanceIPV6] = *instance.Attributes[cloudmap.AttrAWSInstanceIPV6]
} else {
cloudMapInstanceAttributes[cloudmap.AttrAWSInstanceIPV4] = *instance.Attributes[cloudmap.AttrAWSInstanceIPV4]
}
cloudMapInstanceAttributes[cloudmap.AttrK8sPod] = *instance.Attributes[cloudmap.AttrK8sPod]
cloudMapInstanceAttributes[cloudmap.AttrK8sNamespace] = *instance.Attributes[cloudmap.AttrK8sNamespace]
cloudMapInstanceAttributes[cloudmap.AttrAppMeshMesh] = *instance.Attributes[cloudmap.AttrAppMeshMesh]
cloudMapInstanceAttributes[cloudmap.AttrAppMeshVirtualNode] = *instance.Attributes[cloudmap.AttrAppMeshVirtualNode]
cloudMapInstanceAttributes[cloudmap.AttrAWSInstancePort] = *instance.Attributes[cloudmap.AttrAWSInstancePort]
cloudMapInstanceInfoMap[*instance.Id] = cloudMapInstanceAttributes
}
return true
},
); err != nil {
return err
}
if len(cloudMapInstanceInfoMap) != expectedInstanceCount {
return fmt.Errorf("instance count mismatch, expected %d found %d", expectedInstanceCount, len(cloudMapInstanceInfoMap))
}
if err := compareInstances(cloudMapInstanceInfoMap, localInstanceInfoMap); err != nil {
return fmt.Errorf("instance info mismatch")
}
return nil
}
func (m *defaultManager) loadExpectedRegistrationInfo(ctx context.Context, ms *appmesh.Mesh, vn *appmesh.VirtualNode, expectedRegisteredPods []*corev1.Pod) (map[string]map[string]string, error) {
//Get Pods that the VirtualNode selects on
var podsList corev1.PodList
var listOptions client.ListOptions
listOptions.Namespace = vn.Namespace
if err := m.k8sClient.List(ctx, &podsList, &listOptions); err != nil {
return nil, err
}
expectedCount := len(expectedRegisteredPods)
localInstanceInfoMap := make(map[string]map[string]string, expectedCount)
for i := range podsList.Items {
pod := &podsList.Items[i]
if m.findPodByName(pod.Name, expectedRegisteredPods) != nil {
instanceAttributeMap := make(map[string]string)
instanceAttributeMap[cloudmap.AttrAWSInstanceIPV4] = pod.Status.PodIP
instanceAttributeMap[cloudmap.AttrK8sPod] = pod.Name
instanceAttributeMap[cloudmap.AttrK8sNamespace] = pod.Namespace
instanceAttributeMap[cloudmap.AttrAppMeshMesh] = awssdk.StringValue(ms.Spec.AWSName)
instanceAttributeMap[cloudmap.AttrAppMeshVirtualNode] = awssdk.StringValue(vn.Spec.AWSName)
instanceAttributeMap[cloudmap.AttrAWSInstancePort] = strconv.Itoa(int(vn.Spec.Listeners[0].PortMapping.Port))
localInstanceInfoMap[pod.Status.PodIP] = instanceAttributeMap
}
}
if len(localInstanceInfoMap) != expectedCount {
return nil, fmt.Errorf("could not match expected pods with pods present in the cluster. expected %d, found %d", expectedCount, len(localInstanceInfoMap))
}
return localInstanceInfoMap, nil
}
func (m *defaultManager) findPodByName(name string, podsToSearch []*corev1.Pod) *corev1.Pod {
for _, p := range podsToSearch {
if p.Name == name {
return p
}
}
return nil
}
func compareInstances(cloudMapInstanceInfo map[string]map[string]string, localInstanceInfo map[string]map[string]string) error {
for cloudMapInstanceId, cloudMapInstanceAttr := range cloudMapInstanceInfo {
localInstanceAttributes := localInstanceInfo[cloudMapInstanceId]
if cloudMapInstanceAttr[cloudmap.AttrAWSInstanceIPV4] != localInstanceAttributes[cloudmap.AttrAWSInstanceIPV4] ||
cloudMapInstanceAttr[cloudmap.AttrAWSInstanceIPV6] != localInstanceAttributes[cloudmap.AttrAWSInstanceIPV6] ||
cloudMapInstanceAttr[cloudmap.AttrK8sPod] != localInstanceAttributes[cloudmap.AttrK8sPod] ||
cloudMapInstanceAttr[cloudmap.AttrK8sNamespace] != localInstanceAttributes[cloudmap.AttrK8sNamespace] ||
cloudMapInstanceAttr[cloudmap.AttrAppMeshMesh] != localInstanceAttributes[cloudmap.AttrAppMeshMesh] ||
cloudMapInstanceAttr[cloudmap.AttrAppMeshVirtualNode] != localInstanceAttributes[cloudmap.AttrAppMeshVirtualNode] ||
cloudMapInstanceAttr[cloudmap.AttrAWSInstancePort] != localInstanceAttributes[cloudmap.AttrAWSInstancePort] {
return fmt.Errorf("instance info mismatch")
}
}
return nil
}