Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support Hostname and Path rewrite in GatewayRoute #453

Closed
cgchinmay opened this issue Mar 4, 2021 · 1 comment
Closed

Add support Hostname and Path rewrite in GatewayRoute #453

cgchinmay opened this issue Mar 4, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@cgchinmay
Copy link
Contributor

Is your feature request related to a problem?
AppMesh API will be adding support to the GatewayRoute which will allow customers to control the default Hostname rewrite and also modify the matched path URL. In addition there will be support for query_parameters based matching.
For more details:
aws/aws-app-mesh-roadmap#73

Describe the solution you'd like
AppMesh Controller CRD for GatewayRoute must be updated to allow customers to utilize this feature.

Note: Path rewriting requests is not valid (grpc/grpc-dotnet#110) in GRPC
Following are the expected changes to the GatewayRoute CRD

apiVersion: appmesh.k8s.aws/v1beta2
kind: GatewayRoute
metadata:
 name: SampleGatewayRoute
 namespace: my-gateway-route-ns
spec:
  awsName: SampleGatewayRoute_my-gateway-route-ns
  #HTTP Gateway Route
  http:
    match:
      # Only one of prefix or path can be specified
      prefix: "/" #Optional string
      path: #Optional
        #Only one of exact or regex can be specified
        exact: "/path" #Optional String
        regex: "regex", #Optional String
      query_parameters: #Optional
        - name: "query_field" #Required String
          match: #Optional
            exact: "value" #Optional String
    action:
      rewrite: #Optional
        prefix: "/rewrittenUri/", #Optional String.
        path: #Optional
          exact: "/rewrittenPath" #Optional String
        hostname: #Optional
          auto_hostname: "enabled" #Optional String. Allowed values are enabled/disabled.
      target: 
        ...
        
  #HTTP2 Gateway Route
  http2:
    #Same as HTTP Gateway Route
    
  #GRPC Gateway Route
  grpc:
    match:
      ...
    action:
      rewrite: #Optional
        hostname: #Optional
          auto_hostname: "enabled" #Optional String. 
      target: 
        ...
-------
@cgchinmay cgchinmay added the enhancement New feature or request label Mar 4, 2021
@cgchinmay cgchinmay self-assigned this Mar 4, 2021
@achevuru achevuru added this to the 1.4.0 milestone Mar 4, 2021
@cgchinmay cgchinmay changed the title Update GatewayRoute CRD to support Hostname and Path rewrite Add support Hostname and Path rewrite in GatewayRoute Mar 8, 2021
@cgchinmay
Copy link
Contributor Author

Fixed with v1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants