Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry Policy converts any input Duration to milliseconds #89

Closed
bigdefect opened this issue Aug 5, 2019 · 1 comment
Closed

Retry Policy converts any input Duration to milliseconds #89

bigdefect opened this issue Aug 5, 2019 · 1 comment
Labels
Bug Something isn't working

Comments

@bigdefect
Copy link
Contributor

Description

We've identified a bug in Retry Policy (#7) in the preview channel API. The duration input into the api gets converted to milliseconds regardless of the input value. The duration itself and the resulting behavior is the same, but it is stored and returned as milliseconds. We're working on fixing the API to persist and return the same value as was put in.

e.g. With an input of:

{
  "virtualRouterName": "my-router",
  "routeName": "my-route",
  "spec": {
      ...
      "retryPolicy" : {
        "maxRetries" : 4,
        "perRetryTimeout" : {
          "unit" : "s",
          "value" : 2
        },
        "httpRetryEvents" : [
          "server-error"
        ]
      }
    }
  }
}

The output will be:

{
  "virtualRouterName": "my-router",
  "routeName": "my-route",
  "spec": {
      ...
      "retryPolicy" : {
        "maxRetries" : 4,
        "perRetryTimeout" : {
          "unit" : "ms",
          "value" : 2000
        },
        "httpRetryEvents" : [
          "server-error"
        ]
      }
    }
  }
}

Workaround

Until the behavior is corrected, you can choose to exclusively use ms durations.

@bigdefect bigdefect added the Bug Something isn't working label Aug 5, 2019
@bigdefect bigdefect assigned bigdefect and unassigned bigdefect Aug 15, 2019
@bigdefect
Copy link
Contributor Author

The fix for this has been deployed to all production regions. If you experience any issues, feel free to open this back up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant