fix(init-templates): add typesRoot compiler option for TypeScript tem…

…plates (#3865) Closes #3830 Given a project structure where the cdk (init) generated `node_modules` has a parent node project with its own `node_modules` folder with failing typescript code, the CDK will not compile because `tsc` traverses the directory structure looking for type definitions. This small change adds the `typesRoot` [compiler option](https://www.typescriptlang.org/docs/handbook/tsconfig-json.html#types-typeroots-and-types) essentially rooting the typescript compiler to look for types under the `cdk_root_folder/node_modules/@types`.
aws · Sep 2, 2019 · 2c9bafa · 2c9bafa
1 parent 9a229d9
commit 2c9bafa
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/packages/aws-cdk/lib/init-templates/app/typescript/tsconfig.json b/packages/aws-cdk/lib/init-templates/app/typescript/tsconfig.json
@@ -16,7 +16,8 @@
     "inlineSourceMap": true,
     "inlineSources": true,
     "experimentalDecorators": true,
-    "strictPropertyInitialization":false
+    "strictPropertyInitialization":false,
+    "typeRoots": ["./node_modules/@types"]
   },
   "exclude": ["cdk.out"]
 }
diff --git a/packages/aws-cdk/lib/init-templates/lib/typescript/tsconfig.json b/packages/aws-cdk/lib/init-templates/lib/typescript/tsconfig.json
@@ -16,7 +16,8 @@
     "inlineSourceMap": true,
     "inlineSources": true,
     "experimentalDecorators": true,
-    "strictPropertyInitialization":false
+    "strictPropertyInitialization":false,
+    "typeRoots": ["./node_modules/@types"]
   },
   "exclude": ["cdk.out"]
 }

diff --git a/packages/aws-cdk/lib/init-templates/sample-app/javascript/tsconfig.json b/packages/aws-cdk/lib/init-templates/sample-app/javascript/tsconfig.json
@@ -19,7 +19,8 @@
     "strictPropertyInitialization":false,
     "allowJs": true,
     "checkJs": true,
-    "noEmit": true
+    "noEmit": true,
+    "typeRoots": ["./node_modules/@types"]
   },
   "exclude": ["cdk.out"]
 }
diff --git a/packages/aws-cdk/lib/init-templates/sample-app/typescript/tsconfig.json b/packages/aws-cdk/lib/init-templates/sample-app/typescript/tsconfig.json
@@ -16,7 +16,8 @@
     "inlineSourceMap": true,
     "inlineSources": true,
     "experimentalDecorators": true,
-    "strictPropertyInitialization":false
+    "strictPropertyInitialization":false,
+    "typeRoots": ["./node_modules/@types"]
   },
   "exclude": ["cdk.out"]
 }