Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-ec2] The static vars defined in ec2.InterfaceVpcEndpointAwsService do not work in 'cn' regions #11140

Closed
rakesh-d opened this issue Oct 27, 2020 · 7 comments
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud bug This issue is a bug. effort/medium Medium work item – several days of effort p1

Comments

@rakesh-d
Copy link

https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-ec2.InterfaceVpcEndpointAwsService.html

There should be a warning to indicate that constants such as InterfaceVpcEndpointAwsService.EC2 won't work in China regions, since the service name has a prefix 'cn.com.amazonaws'


This is a 📕 documentation issue

@rakesh-d rakesh-d added documentation This is a problem with documentation. feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 27, 2020
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Oct 27, 2020
@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 2, 2020

They should be made to work. Thanks for the call-out.

@rix0rrr rix0rrr added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 and removed documentation This is a problem with documentation. feature-request A feature should be added or improved. labels Nov 2, 2020
@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 2, 2020

The solution is probably to go through region-info.

@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Nov 2, 2020
@flemjame-at-amazon
Copy link
Contributor

flemjame-at-amazon commented Nov 6, 2020

The workaround for this is to provide the prefix in the constructor for a new InterfaceVpcEndpointAwsService(...)

@rakesh-d
Copy link
Author

rakesh-d commented Nov 7, 2020

Note that this prefix is not consistent across services. Some services have the extra 'cn.' prefix while others do not. It's probably going to be an ugly fix.

@flemjame-at-amazon
Copy link
Contributor

@rix0rrr is it possible to have the CDK project automatically pull in some information? Long-lived things like these prefixes fit nicely in there.

@corymhall
Copy link
Contributor

This was fixed in #16139.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud bug This issue is a bug. effort/medium Medium work item – several days of effort p1
Projects
None yet
Development

No branches or pull requests

5 participants