Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(elasticloadbalancing): rename 'sslCertificateId' property of LB listener to 'sslCertificateArn'; deprecate sslCertificateId property #13766

Merged
merged 8 commits into from
Apr 12, 2021
Merged

feat(elasticloadbalancing): rename 'sslCertificateId' property of LB listener to 'sslCertificateArn'; deprecate sslCertificateId property #13766

merged 8 commits into from
Apr 12, 2021

Conversation

OksanaH
Copy link
Contributor

@OksanaH OksanaH commented Mar 24, 2021 •
edited
Loading

The property sslCertificateId of the LoadBalancer listener actually means sslCertificateArn. So as suggested in #9303, I have deprecated sslCertificateId and replaced it by sslCertificateArn to better reflect its actual meaning.

fixes #9303

@gitpod-io
Copy link

gitpod-io bot commented Mar 24, 2021 •
edited
Loading

@github-actions github-actions bot added the @aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing label Mar 24, 2021
@OksanaH OksanaH changed the title feat(elasticloadbalancing): rename 'sslCertificateId' property of LB listener to 'sslCertificateArn'; deprecate sslCertificateId property #9303 feat(elasticloadbalancing): rename 'sslCertificateId' property of LB listener to 'sslCertificateArn'; deprecate sslCertificateId property Mar 24, 2021
njlynch
njlynch previously requested changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I made a few minor suggestions for improvements.

packages/@aws-cdk/aws-elasticloadbalancing/lib/load-balancer.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-elasticloadbalancing/lib/load-balancer.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-elasticloadbalancing/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-elasticloadbalancing/lib/load-balancer.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed njlynch’s stale review March 30, 2021 21:20

Pull request has been modified.

@njlynch njlynch added the pr-linter/exempt-readme The PR linter will not require README changes label Mar 31, 2021
@OksanaH
feat(elasticloadbalancing): add test to verify that an error is throw…
6ad9107 
…n when both sslCertificateId and sslCertificateArn are used
njlynch
njlynch previously approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@mergify
Copy link
Contributor

mergify bot commented Apr 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed njlynch’s stale review April 9, 2021 15:53

Pull request has been modified.

@OksanaH
Copy link
Contributor Author

OksanaH commented Apr 11, 2021

@njlynch, looks like the build has failed - is there something that I need to do to resolve this issue? Thanks

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: b3e0d9e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 12, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1a30272 into aws:master Apr 12, 2021
@njlynch
Copy link
Contributor

njlynch commented Apr 12, 2021

looks like the build has failed - is there something that I need to do to resolve this issue? Thanks

Our @aws-cdk/assert library was renamed to @aws-cdk/assert-internal, which caused the build to fail. I fixed it for you in the diff, and it's merging cleanly now. Thanks again for the contribution!

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@OksanaH @hollanddd
feat(elasticloadbalancing): rename 'sslCertificateId' property of LB …
e5cbef5 
…listener to 'sslCertificateArn'; deprecate sslCertificateId property (aws#13766)

The property `sslCertificateId` of the LoadBalancer listener actually means sslCertificateArn. So as suggested in aws#9303, I have deprecated `sslCertificateId` and replaced it by `sslCertificateArn` to better reflect its actual meaning.

fixes aws#9303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njlynch njlynch njlynch approved these changes

Assignees

@njlynch njlynch

Labels
@aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[elasticloadbalancing] Clarify expected value of sslCertificateId property of LoadBalancerListener is an ARN
3 participants
@OksanaH @aws-cdk-automation @njlynch