Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-ecs): add Cluster.fromLookup() #14032

Closed
2 tasks
misterjoshua opened this issue Apr 7, 2021 · 7 comments
Closed
2 tasks

(aws-ecs): add Cluster.fromLookup() #14032

misterjoshua opened this issue Apr 7, 2021 · 7 comments
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@misterjoshua
Copy link
Contributor

misterjoshua commented Apr 7, 2021

I'd like the L2 ECS Cluster construct to have a fromLookup() that acts like many of the other L2 construct fromLookup() methods.

Use Case

I want to look up an ECS cluster defined in another stack.

Proposed Solution

// Look up the cluster
const cluster = ecs.Cluster.fromLookup(this, 'Cluster', {
  tags: { Name: 'OtherStack/Whatever/Here' },
});

// Create an EC2-based service in the looked-up cluster
new ecs.Ec2Service(this, 'Service', {
  cluster,
  //...
});
  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@misterjoshua misterjoshua added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 7, 2021
@peterwoodworth peterwoodworth added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Apr 8, 2021
@SoManyHs SoManyHs added p2 and removed needs-triage This issue or PR still needs to be triaged. labels Apr 22, 2021
@SoManyHs SoManyHs added the effort/medium Medium work item – several days of effort label Apr 22, 2021
@dsinghvi
Copy link

When is this going to be released? Or is there a workaround?

@waifa
Copy link

waifa commented Dec 16, 2022

Also looking for this feature, any updates?

@github-actions
Copy link

This issue has received a significant amount of attention so we are automatically upgrading its priority. A member of the community will see the re-prioritization and provide an update on the issue.

@crazyzelot
Copy link

Does this have any kind of ETA?

@DavidDryja
Copy link

+1 on wanting this implemented

@pahud
Copy link
Contributor

pahud commented May 24, 2024

Why do we need fromLookup() given we already have fromClusterAttributes()?

public static fromClusterAttributes(scope: Construct, id: string, attrs: ClusterAttributes): ICluster {

Can someone share the use cases?

@pahud pahud added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label May 24, 2024
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants