-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yaml-cfn: deprecation #14161
Comments
Hi @peterwoodworth thanks for the response! I've looked at #14001 and not sure what the workaround/solution is. Is yaml parsing now a part of cdk.core? So do I have to use some non-aws package for importing yaml into CDK scripts? |
Hey @smaud, Actually in practice, nothing has changed since that PR. SO, rather than conceding the point, it was migrated to solely exist in each package it was required in. The code from the original package was just copied and pasted into the dependent packages. I realize this is semantic, but it allowed us to maintain our standards. In practice, you should be able to use the I hope that helps! 😸 😷 |
thanks @NGL321, I think I understand, but I don't know how to implement what you've just said. What I'm asking for is doco. What do I do in my code? import * as cdk from '@aws-cdk/core';
import * as yaml from '@aws-cdk/yaml-cfn';
const myJSON = yaml.deserialize(readFileSync(myYAMLFile, 'utf-8').toString());
OR import * as cdk from '@aws-cdk/core';
const myJSON = cdk.yaml.deserialize(readFileSync(myYAMLFile, 'utf-8').toString()); Could you please provide an example? |
@smaud It looks like the yaml-cfn package was only absorbed privately and isn't public anymore. This package was more intended to be used by us and not really by CDK users. So I don't think there's a way for you to just use the serialize/deserialize functions natively with the CDK. That said, it should be pretty easy to implement those functions in your own project. Create a new file and paste this code into it, then simply call these functions wherever you need. Make sure you |
Thanks @peterwoodworth, One of the KPIs we will be aiming to implement in our contract with AWS is zero workarounds, which means we don't need to implement these functions. The expectation here then is that the CDK & Cloudformation teams, will support and maintain a package which converts yaml file formats to json because it is a feature of AWS cloud services. How should I request this feature through my TAM? |
I'll handle this feature request myself - no need to go through the TAM since you're already right here! I'll have an update for you tomorrow 😄 If a TAM becomes necessary I'll let you know |
Hey @smaud, Unfortunately Peter was incorrect in his assessment that readding this is a good feature-request. If you are simply looking for a method to convert yaml to json, I highly recommend you check our the Cheers |
|
Hi @NGL321 Please see my message above. In AWS SysOps we will use yaml for the specification of EC2 Imagebuilder components and recipes in our CDK. The requirement is to convert the yaml to a json format, so that the Typescript can make appropriate additions to our CDK implementation. Using AWS Cloud Native tools means zero third party dependencies. Hence an AWS supported yaml converter to json is required. We do not have an SLA with the vendor of js-yaml. Please advise if we need to raise the request with out AWS TAM if that is the preferred method. |
I appreciate your concern, but as an open source project, our goal with the CDK is to ensure we can meet the needs of our users as well as maintain rigorous standards for the project. If you would like to determine that through more official channels, reaching out to your TAM would be a good approach, and we can have this conversation through internal AWS ticketing. 😸 😷 |
Ok I’ll raise this as a feature request through our TAM and we can track it in the CDK project timeline.
Alternatively if you want to provide an example of how to use cdk to build golden ami with building components locally, please send me a link.
Just as a quick note, although CDK is open source, it is also a product that is supported by AWS and covered under our Enterprise SLA. So being open source anyone can contribute, however in supporting the CDK, AWS needs to be responsive to Enterprise feature requirements, and yaml is one requirement moving forward.
|
❓ General Issue
Deprecation notice
The Protest
HEY! I was using that!
Don't just remove a useful utility!
Please give some advice on an alternative we can use
Environment
Other information
The text was updated successfully, but these errors were encountered: