feat(ecs-patterns): pass securityGroups to ScheduledFargateTask

[crazymykl]

closes #5213

This is a minimal approach.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[mergify]

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

[gitpod-io]

[fongie]

just struggled with this in my project: this would be a nice feature

[RajarsiGit]

just struggled with this in my project: this would be a nice feature

Hi, @fongie can you share you code please, wherein you have overcome this issue using some way? Thanks

[RajarsiGit]

Looks good to me

[fongie]

just struggled with this in my project: this would be a nice feature

Hi, @fongie can you share you code please, wherein you have overcome this issue using some way? Thanks

Hi! Sure, but I warn you it's not pretty and there might be a better way too :)

  private addSecurityGroupToScheduledTask(group: SecurityGroup, task: ScheduledFargateTask) {
    const rule = task.eventRule as any as CfnRule
    const targets = rule.targets as any as RuleTargetConfig[]
    const config = targets[0].ecsParameters!.networkConfiguration as any
    const groups = config.awsVpcConfiguration.securityGroups as Array<string>
    groups.push(group.securityGroupId)
  }

This adds the security group you pass in to the method to the security groups of the task. Then, you can configure connections via the security group (like allowfrom, to, etc). Note that it also keeps the default security group.

[SoManyHs]

This is great! Do you think you could also add this to the ScheduledEc2Task as well?

[SoManyHs]

I went ahead and added the change to support Ec2 patterns on top of your work here: #15096

[crazymykl]

Nice. I was having some trouble figuring out how to unit test that case.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: 02fc4d8
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[SoManyHs]

Just curious, is it critical that you can reference the securityGroup as an output property on the ScheduledFargateTask after it is created? I.e. https://github.com/aws/aws-cdk/pull/14220/files#diff-7ebbca721fecf8f6c66398af515f1d264cbdf3116d34ef912aab19a55e06994aR39-R43?

[SoManyHs]

Resolved by #15096