Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): add warning to fargateProfile #16631

Merged
merged 2 commits into from Sep 23, 2021
Merged

feat(eks): add warning to fargateProfile #16631

merged 2 commits into from Sep 23, 2021

Conversation

peterwoodworth
Copy link
Contributor

@peterwoodworth peterwoodworth commented Sep 23, 2021

partially fixes #16349


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Sep 23, 2021

@peterwoodworth peterwoodworth added @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort p1 pr-linter/exempt-readme The PR linter will not require README changes labels Sep 23, 2021
@peterwoodworth peterwoodworth added pr-linter/exempt-test The PR linter will not require test changes contribution/core This is a PR that came from AWS. labels Sep 23, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: a6587ad
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 41fdebb into aws:master Sep 23, 2021
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@peterwoodworth peterwoodworth deleted the warning branch September 23, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p1 pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(eks): clarify that vpc prop is necessary for subnetSelection prop to work in FargateProfile construct
3 participants