Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda): docker image function fails when insightsVersion is specified #16781

Merged
merged 4 commits into from Oct 14, 2021

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Oct 4, 2021

Lambda insights is configured as a set of layers that are then
auto-added to the lambda function when the insightsVersion property is
specified.

However, Lambda functions deployed as container images cannot contain
layers. Instead, the user is expected to bring a container image with
the Insights agent pre-installed.

Update the CDK code, so that the layer is not added for Lambda functions
that use container images.

fixes #16642


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…ified

Lambda insights is configured as a set of layers that are then
auto-added to the lambda function when the `insightsVersion` property is
specified.

However, Lambda functions deployed as container images cannot contain
layers. Instead, the user is expected to bring a container image with
the Insights agent pre-installed.

Update the CDK code, so that the layer is not added for Lambda functions
that use container images.

fixes #16642
@nija-at nija-at requested a review from a team October 4, 2021 14:03
@nija-at nija-at self-assigned this Oct 4, 2021
@gitpod-io
Copy link

gitpod-io bot commented Oct 4, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 4, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 3015109
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d0e15cc into master Oct 14, 2021
@mergify mergify bot deleted the nija-at/lambda-container-insights branch October 14, 2021 07:08
@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…ified (aws#16781)

Lambda insights is configured as a set of layers that are then
auto-added to the lambda function when the `insightsVersion` property is
specified.

However, Lambda functions deployed as container images cannot contain
layers. Instead, the user is expected to bring a container image with
the Insights agent pre-installed.

Update the CDK code, so that the layer is not added for Lambda functions
that use container images.

fixes aws#16642


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-lambda): docker image function fails with insightsVersion property
3 participants