New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws-ecs): check for invalid capacityProviderName #17291
fix(aws-ecs): check for invalid capacityProviderName #17291
Conversation
chore(aws-ecs): update capacityProviderName Description
Hi @peterwoodworth, do you have a free to take a look this PR, thank you. :) |
Thanks for the contribution @neilkuan! is there any original issue which this is meant to close? And if not, could you create one to describe the issue that needs to be fixed? Thanks |
thank @peterwoodworth , already create the issue #17321. |
I think this looks good - I don't think this would be a breaking change. @madeline-k should verify though |
Hi @madeline-k , do you have a free to take a look this PR, thank you. :) |
Hi @peterwoodworth, actually this PR adds a pre-check in CDK to avoid possible deployment failure and does not add any new features. It doesn't make sense to update the README to pass the lint. Let's classify it as chore or fix. wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @madeline-k can you take a look please? |
Hi @neilkuan , can you please resolve the conflicts before we can merge this PR? |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
fix(aws-ecs): add precheck name of capacity provider when specify it. chore(aws-ecs): update capacityProviderName Description close aws#17321 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
fix(aws-ecs): add precheck name of capacity provider when specify it.
chore(aws-ecs): update capacityProviderName Description
close #17321
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license