Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eks): cannot customize alb controller repository and version #18081

Merged
merged 2 commits into from Dec 19, 2021
Merged

fix(eks): cannot customize alb controller repository and version #18081

merged 2 commits into from Dec 19, 2021

Conversation

kirintwn
Copy link
Contributor

Close #18054

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 18, 2021

@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Dec 18, 2021
iliapolo
iliapolo previously approved these changes Dec 19, 2021
View reviewed changes
Copy link
Contributor

@iliapolo iliapolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@mergify
Copy link
Contributor

mergify bot commented Dec 19, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@iliapolo iliapolo changed the title fix(eks): fix wrong alb controller helm values fix(eks): cannot customize alb controller repository and version Dec 19, 2021
@mergify mergify bot dismissed iliapolo’s stale review December 19, 2021 13:07

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 914de22
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kirintwn
Copy link
Contributor Author

@iliapolo I think you need to approve the PR again since it was marked as modified

@mergify mergify bot merged commit e4256c8 into aws:master Dec 19, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 19, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@kirintwn @TikiTDO
fix(eks): cannot customize alb controller repository and version (aws…
7b03d6f 
…#18081)

Close aws#18054

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliapolo iliapolo iliapolo approved these changes

Assignees

@otaviomacedo otaviomacedo

Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-eks): ALB Controller wrong value keys for repository and tag in HelmChart
4 participants
@kirintwn @aws-cdk-automation @iliapolo @otaviomacedo