Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docdb): allow setting log retention #18120

Merged
merged 3 commits into from Dec 22, 2021
Merged

Conversation

jumic
Copy link
Contributor

@jumic jumic commented Dec 21, 2021

Provide an option to configure the number of days log events are kept in CloudWatch Logs.
Properties cloudwatchLogsRetention and cloudwatchLogsRetentionRole are added to DatabaseClusterProps.

Closes #13191.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 21, 2021

@github-actions github-actions bot added the @aws-cdk/aws-docdb Related to Amazon DocumentDB label Dec 21, 2021
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @jumic! Just a small naming comment.

packages/@aws-cdk/aws-docdb/lib/cluster.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-docdb/lib/cluster.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed skinny85’s stale review December 21, 2021 22:07

Pull request has been modified.

@jumic jumic requested a review from skinny85 December 21, 2021 22:08
@skinny85 skinny85 changed the title feat(docdb): logs retention option feat(docdb): allow setting log retention Dec 21, 2021
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed changing the docs, and I missed a redundant condition in an if 😃.

packages/@aws-cdk/aws-docdb/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-docdb/lib/cluster.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed skinny85’s stale review December 21, 2021 22:34

Pull request has been modified.

@jumic
Copy link
Contributor Author

jumic commented Dec 21, 2021

Thanks for your feedback. The suggested changes have been implemented. :)

@jumic jumic requested a review from skinny85 December 21, 2021 22:39
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 1ce9273
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot merged commit 002202f into aws:master Dec 22, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Provide an option to configure the number of days log events are kept in CloudWatch Logs.
Properties `cloudwatchLogsRetention` and `cloudwatchLogsRetentionRole` are added to `DatabaseClusterProps`.

Closes aws#13191.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-docdb Related to Amazon DocumentDB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-docdb): bring cloudwatch support on aws-docdb DatabaseCluster
3 participants