Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lambda): dotnet6 runtime #19144

Merged
merged 2 commits into from Mar 10, 2022
Merged

feat(lambda): dotnet6 runtime #19144

merged 2 commits into from Mar 10, 2022

Conversation

PatMyron
Copy link
Contributor

@PatMyron PatMyron commented Feb 24, 2022 •
edited

@gitpod-io
Copy link

gitpod-io bot commented Feb 24, 2022

@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Feb 24, 2022
Roman-Blinkov
Roman-Blinkov approved these changes Feb 25, 2022
View reviewed changes
Copy link

@Roman-Blinkov Roman-Blinkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you man.

@peterwoodworth peterwoodworth added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes labels Feb 25, 2022
@peterwoodworth
Copy link
Contributor

@PatMyron is this ready on CloudFormation's side of things?
The runtime isn't listed as an accepted runtime yet in the docs
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-lambda-function.html#cfn-lambda-function-runtime

@PatMyron
Copy link
Contributor Author

PatMyron commented Mar 1, 2022 •
edited

@peterwoodworth CloudFormation resource provider schema for AWS::Lambda::Function doesn't have any upfront constraints on Runtime

@drewdelano
Copy link

drewdelano commented Mar 3, 2022 •
edited

@peterwoodworth this is a fairly recent change, so the docs are probably out of date:

aws/aws-lambda-dotnet#889 (comment)

image

kaizencc
kaizencc previously approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@mergify mergify bot dismissed kaizencc’s stale review March 10, 2022 21:28

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 9a73445
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 10, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit bbed27d into aws:master Mar 10, 2022
@PatMyron PatMyron deleted the patch-1 branch March 10, 2022 22:47
@peterwoodworth peterwoodworth mentioned this pull request Mar 11, 2022
Closed
TheRealAmazonKendra pushed a commit to TheRealAmazonKendra/aws-cdk that referenced this pull request Mar 11, 2022
@PatMyron @TheRealAmazonKendra
feat(lambda): dotnet6 runtime (aws#19144)
1564dfd 
fix aws/aws-lambda-dotnet#1088, fix aws#19148
https://aws.amazon.com/about-aws/whats-new/2022/02/aws-lambda-adds-support-net6/
https://aws.amazon.com/blogs/compute/introducing-the-net-6-runtime-for-aws-lambda/
https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roman-Blinkov Roman-Blinkov Roman-Blinkov approved these changes

@peterwoodworth peterwoodworth peterwoodworth approved these changes

@kaizencc kaizencc kaizencc left review comments

Assignees

@kaizencc kaizencc

Labels
@aws-cdk/aws-lambda Related to AWS Lambda pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-lambda): Add support for dotnet 6 How to set dotnet6 runtime in CDK?
6 participants
@PatMyron @peterwoodworth @drewdelano @aws-cdk-automation @Roman-Blinkov @kaizencc